-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automation of Rosa Scaling Benchmark (#444): Part 2 #492
Conversation
@andyuk1986 - thank you for preparing calculation of the results. I pushed some small code syntax change, I hope they don't break anything while making the code a bit simpler to read. The The calculations look good for the requests per seconds for both users and clients looks good. The calculation for memory is probably off: The Looking at the JSON, this is a JSON I found in one of your runs:
I ask you to make the result a simple value so it can be used in reports. It shouldn't be quoted as it is a number, not a string. Due to that, the naming changed a little, and I also tried to shorten it.
Please let me know if you have questions. |
eb9b965
to
71e4808
Compare
@ahus1 hi, thanks a lot for the review. I have updated PR with suggested changes.
|
3240be3
to
226727b
Compare
226727b
to
ba6b5e9
Compare
fd4a79b
to
b5b696d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution. Its great that we now have this automation to calculate the metrics by the click of a button within one hour.
I did two small changes:
- Adding a
|tonumber
to thejq
command to have the value printed without quotes, so it can be processed in future steps without converting it from a string to a number - Masking the value of
OC_TOKEN
so it doesn't show up in the console.
PR contains:
The workflow execution for 5 minutes gives the following JSON:
Closes #444