Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A/P failure testing #495 #507

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Conversation

ryanemerson
Copy link
Contributor

No description provided.

HTTP health checks continue to succeed when no keycloak pods exist as a
TLS EOF exception is encountered, not a 5xx response code.
@kami619
Copy link
Contributor

kami619 commented Sep 1, 2023

@ryanemerson there seems to be a failure in the Ascii docs tests

Copy link
Contributor

@kami619 kami619 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall the changes look good to me. We can work any fixes if need be in subsequent issues and tickets.

@ryanemerson
Copy link
Contributor Author

Docs should be fixed. I just needed to escape ${DOMAIN} with $\{DOMAIN}.

Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ryanemerson

@mhajas mhajas merged commit 545c924 into keycloak:main Sep 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants