Keycloak derives memory settings from container limit #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kami619
reviewed
Feb 19, 2024
doc/benchmark/modules/ROOT/pages/report/rosa-benchmark-key-results.adoc
Outdated
Show resolved
Hide resolved
kami619
reviewed
Feb 19, 2024
| {{ if .Values.cpuLimits }}cpu: "{{ .Values.cpuLimits }}"{{end}} | ||
| {{ if .Values.memoryLimitsMB }}memory: "{{ .Values.memoryLimitsMB }}M"{{end}} | ||
| # end::keycloak[] | ||
| # readinessProbe: |
There was a problem hiding this comment.
do we want to leave the trace for probes for future use ?
There was a problem hiding this comment.
sure, we can keep that.
kami619
approved these changes
Feb 19, 2024
Relates to keycloak/keycloak#27078 Co-authored-by: Kamesh Akella <kakella@redhat.com> Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
ahus1
force-pushed
the
resource-limits-based-on-percentage
branch
from
0986c80
to
8471454
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to keycloak/keycloak#27078
The 300 MB no-heap usage are a preliminary value with manual tests on OpenShift. We'll need to watch the nightly tests to confirm that value.
In my tests I've seen values up to 240 MB, and 300 MB is assumed to be on the safe side.