Reapply "Upgrade to Infinispan 15.0.3.Final" #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhajas
approved these changes
May 14, 2024
There was a problem hiding this comment.
Thank you @ryanemerson, I can confirm today's clusters already contain the correct version of ISPN operators == 2.4.1.
I believe it is safe to merge this now even when today's kcb deployment still contains 14.0.27 ISPN.
+1. If we require 15.0.x then it's just a case of redeploying Infinispan/Keycloak with the latest code on our clusters. |
pruivo
reviewed
May 14, 2024
| @@ -22,8 +22,6 @@ data: | |||
| cacheContainer: | |||
| metrics: | |||
| namesAsTags: true | |||
| gauges: true | |||
| histograms: {{ .Values.metrics.histograms }} | |||
There was a problem hiding this comment.
any reason to remove this line?
There was a problem hiding this comment.
I have no idea why I did that. I should have just removed gauges as we're using the default value. Reverted
This reverts commit 1be39e9. Signed-off-by: Ryan Emerson <remerson@redhat.com>
ryanemerson
force-pushed
the
infinispan_15
branch
from
f21a2bf
to
a83461d
Compare
pruivo
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Operator PR finally got merged, so we should be good to reapply my original fix: redhat-openshift-ecosystem/community-operators-prod#4512