Deploy Infinispan with maxCount=10000 and num_owners=1

[ryanemerson]

Resolves #805

[ahus1]

Hi @ryanemerson - see below for my comments. One overall requirement I'd see: Those changes should only apply when persistent sessions are enabled.

Unfortunately a remedy to the bug we're handling in keycloak/keycloak#29592 might be not to apply this change in the external Infinispan.

With that recent development, I'd suggest to put this issue on hold until the other issue resolved. We would then revisit it again once the remote-store only changes from #28745 are in. But even then I'm not sure how an cache with maxCount and amnd xsite setup can maintain entries that are not outdated, as a remove in the primary site for a key that exists only in the secondary site will never reach the secondary site.

cc: @pruivo @mhajas

[ahus1]

The changes about owners and max-count should be active only when persistent sessions are enabled. At the moment Keycloak does those settings automatically in the CacheManagerFactory. Although this would prints an INFO message, I'd rather have the message in the log than maintaining two different configurations. So I'd ask you to revert the changes in this file.

[ahus1]

@ryanemerson - update to my previous comment: The PR keycloak/keycloak#29597 might still allow for an external Infinispan with maxCount, let's continue the discussion next week.

[mhajas]

@ryanemerson Is ISPN operator able to update existing caches with maxCount and owners? I remember that some time ago when I tried to change something in CR Operator refused to change it.

[ryanemerson]

@ryanemerson Is ISPN operator able to update existing caches with maxCount and owners? I remember that some time ago when I tried to change something in CR Operator refused to change it.

Yes this is possible when the default strategy of spec.updates.strategy: retain is used on the Cache CR. The Operator will attempt to update the cache configuration on the server to equal that of the CR, however the operation will fail if the old and new configuration are incompatible for a runtime update.

https://infinispan.org/docs/infinispan-operator/main/operator.html#updating_cache_creating-caches

Other PR is now merged, we are now safe to proceed as long as we do this only for persistent sessions enabled.

[ahus1]

@ryanemerson - the issues to handle the expiry of sessions is now resolved as the other PR is merged.

Could you please now attend to the other issue: Your changes should only apply when persistent sessions are enabled, as limiting the number of entries is otherwise not supported.

Thanks!

[ryanemerson]

Suggestions added

[ryanemerson]

Your changes should only apply when persistent sessions are enabled, as limiting the number of entries is otherwise not supported.

It should be good now. If KC_PERSISTENT_SESSIONS is true when provisioning the Infinispan cluster then cache configs are updated accordingly.

[kami619]

merging it, as its approved by @pruivo