-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy Infinispan with maxCount=10000 and num_owners=1 #818
Deploy Infinispan with maxCount=10000 and num_owners=1 #818
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ryanemerson - see below for my comments. One overall requirement I'd see: Those changes should only apply when persistent sessions are enabled.
Unfortunately a remedy to the bug we're handling in keycloak/keycloak#29592 might be not to apply this change in the external Infinispan.
With that recent development, I'd suggest to put this issue on hold until the other issue resolved. We would then revisit it again once the remote-store only changes from #28745 are in. But even then I'm not sure how an cache with maxCount and amnd xsite setup can maintain entries that are not outdated, as a remove in the primary site for a key that exists only in the secondary site will never reach the secondary site.
@@ -37,19 +37,23 @@ | |||
</encoding> | |||
<memory max-count="10000"/> | |||
</local-cache> | |||
<distributed-cache name="sessions" owners="2"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes about owners and max-count should be active only when persistent sessions are enabled. At the moment Keycloak does those settings automatically in the CacheManagerFactory
. Although this would prints an INFO message, I'd rather have the message in the log than maintaining two different configurations. So I'd ask you to revert the changes in this file.
@ryanemerson - update to my previous comment: The PR keycloak/keycloak#29597 might still allow for an external Infinispan with maxCount, let's continue the discussion next week. |
@ryanemerson Is ISPN operator able to update existing caches with |
Yes this is possible when the default strategy of https://infinispan.org/docs/infinispan-operator/main/operator.html#updating_cache_creating-caches |
Other PR is now merged, we are now safe to proceed as long as we do this only for persistent sessions enabled.
@ryanemerson - the issues to handle the expiry of sessions is now resolved as the other PR is merged. Could you please now attend to the other issue: Your changes should only apply when persistent sessions are enabled, as limiting the number of entries is otherwise not supported. Thanks! |
bb85891
to
8fbe24e
Compare
Suggestions added |
8fbe24e
to
98127b9
Compare
Closes keycloak#805 Signed-off-by: Ryan Emerson <remerson@redhat.com>
98127b9
to
8ed29da
Compare
It should be good now. If |
merging it, as its approved by @pruivo |
Resolves #805