Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 21 #917

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Java 21 #917

merged 2 commits into from
Aug 8, 2024

Conversation

ryanemerson
Copy link
Contributor

No description provided.

Signed-off-by: Ryan Emerson <remerson@redhat.com>
@ryanemerson
Copy link
Contributor Author

Closing as we either need Scala 2.3.15 or we need to migrate to Scala 3 before we can upgrade: https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html

@ryanemerson ryanemerson closed this Aug 7, 2024
@ahus1 ahus1 reopened this Aug 8, 2024
@ahus1
Copy link
Contributor

ahus1 commented Aug 8, 2024

Reading the table, I see that Scala 2.13.11 support JDK 21. Looking at Gatling 3.10.5, it uses Scala 2.13.13, which should work. I'll push a commit.

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
@ryanemerson ryanemerson merged commit bb6c819 into keycloak:main Aug 8, 2024
2 of 3 checks passed
@ryanemerson
Copy link
Contributor Author

It seems my reading comprehension deteriorates dramatically as we approach the end of the day 😅

Thanks for fixing this up @ahus1. Merging as the minikube failure is also present on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants