Skip to content

fix(windows): contextual help chm file has blank pages#15724

Open
sze2st wants to merge 2 commits intomasterfrom
fix/windows/15571-contextual-help-chm-file-has-blank-pages
Open

fix(windows): contextual help chm file has blank pages#15724
sze2st wants to merge 2 commits intomasterfrom
fix/windows/15571-contextual-help-chm-file-has-blank-pages

Conversation

@sze2st
Copy link
Copy Markdown
Contributor

@sze2st sze2st commented Mar 11, 2026

fixes: #15571
These changes fixes the issue of empty subchapters of chapter "contextual help" in windows chm help file.

Build-bot: release:windows

@github-project-automation github-project-automation bot moved this to Todo in Keyman Mar 11, 2026
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Mar 11, 2026
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Mar 11, 2026

User Test Results

Test specification and instructions

  • TEST_CONTEXTUAL_HELP (OPEN)
Results Template
# Test Results

* **TEST_CONTEXTUAL_HELP (OPEN):** notes

Test Artifacts

  • Android
    • Keyman for Android apk - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for Android apk - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for Android apk (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • KeyboardHarness apk - build : all tests passed (no artifacts on BuildLevel "build")
    • Keyman for Android apk (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • KMSample1 apk - build : all tests passed (no artifacts on BuildLevel "build")
    • KMSample2 apk - build : all tests passed (no artifacts on BuildLevel "build")
  • Developer
    • Keyman Developer - build : all tests passed (no artifacts on BuildLevel "build")
    • Compiler Regression Tests - build : all tests passed (no artifacts on BuildLevel "build")
    • Keyman Developer (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • kmcomp.zip - build : all tests passed (no artifacts on BuildLevel "build")
    • kmcomp.zip (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
  • iOS
    • Keyman for iOS (simulator image) - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for iOS (simulator image) - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for iOS (simulator image) (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • Keyman for iOS (simulator image) (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
  • Keyboards
    • Test Keyboards - build : all tests passed (no artifacts on BuildLevel "build")
  • macOS
    • Keyman for macOS - build : all tests passed (no artifacts on BuildLevel "build")
    • Keyman for macOS (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
  • Web
    • KeymanWeb Test Home - build : all tests passed (no artifacts on BuildLevel "build")
  • Windows

@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S24 milestone Mar 11, 2026
@sze2st
Copy link
Copy Markdown
Contributor Author

sze2st commented Mar 11, 2026

User Testing

  • TEST_CONTEXTUAL_HELP
  • open Keyman for Windows User Guide by double click on keymandesktop.chm
  • In content on left hand side expand first chapter "Keyman for Windows 19.0 Help"
  • Expand subchapter "Contextual Help"
  • click on any of the subchapters of "Contextual Help" (e.g. "set hotkey"): The right hand side should not only come with a headline but with detailed description.
  • NOTE: When clicking on a subchapter of "Contextual Help" the focus of the content will change. e.g. when clicking on "set hotkey" will change to subchapter "How To - Set Hotkeys for Keyman, Keyman Keyboards and Windows Languages" of chapter "Getting Started on Windows".
    (Same already happens when using html file instead of chm and is caused by internal linking. This issue is not part of the current fix)

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed and removed user-test-missing User tests have not yet been defined for the PR labels Mar 11, 2026
@sze2st sze2st changed the title in function Meta: consider AST correctly for setting redirect fix(windows): contextual help chm file has blank pages Mar 12, 2026
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this LGTM, although I am not sure why the old code wasn't working?

@keyman-server keyman-server modified the milestones: A19S24, A19S25 Mar 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

bug(windows): contextual help chm file has blank pages

3 participants