feat(web): map suggestions to their source tokenizations 🚂#15767
Draft
jahorton wants to merge 1 commit intorefactor/web/create-default-keepfrom
Draft
feat(web): map suggestions to their source tokenizations 🚂#15767jahorton wants to merge 1 commit intorefactor/web/create-default-keepfrom
jahorton wants to merge 1 commit intorefactor/web/create-default-keepfrom
Conversation
Each suggestion comes from a specific variant of the context (per whitespace fat-fingering). In order to properly apply a suggestion, we'll need to apply it to that specific variant, which is represented by a specific instance of ContextTokenization. This PR constructs a map that remembers the correlation between suggestion and source context variant. At the current level of implementation, there's only the one possible source... though that will be changing in upcoming work. Ensuring that the suggestion is properly applied will be handled separately as part of that work. Build-bot: skip build:web Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each suggestion comes from a specific variant of the context (per whitespace fat-fingering). In order to properly apply a suggestion, we'll need to apply it to that specific variant, which is represented by a specific instance of ContextTokenization. This PR constructs a map that remembers the correlation between suggestion and source context variant.
At the current level of implementation, there's only the one possible source... though that will be changing in upcoming work. Ensuring that the suggestion is properly applied will be handled separately as part of that work.
Build-bot: skip build:web
Test-bot: skip