change(web): rework suggestion-application range calculation 🚂#15782
Draft
jahorton wants to merge 2 commits intorefactor/web/build-and-map-predictionsfrom
Draft
change(web): rework suggestion-application range calculation 🚂#15782jahorton wants to merge 2 commits intorefactor/web/build-and-map-predictionsfrom
jahorton wants to merge 2 commits intorefactor/web/build-and-map-predictionsfrom
Conversation
This PR calculates the magnitude of left-deletes needed when applying a suggestion via a new approach better suited toward operation under whitespace fat-fingering conditions. The new method also determines a range of context - possibly comprised of multiple tokens - that should comprise predictions, but doesn't yet do anything with that part. Build-bot: skip build:web Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
github-actions
bot
added
web/
web/predictive-text/
change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR calculates the magnitude of left-deletes needed when applying a suggestion via a new approach better suited toward operation under whitespace fat-fingering conditions.
The new method also determines a range of context - possibly comprised of multiple tokens - that should comprise predictions, but doesn't yet do anything with that part.
Build-bot: skip build:web
Test-bot: skip