chore: #81 Make fields final when they can be final (found by the…

… corresponding inspection).
kghackers · Nov 22, 2024 · 7aa1fdd · 7aa1fdd
1 parent 2e76770
commit 7aa1fdd
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/...v/src/main/java/ru/klavogonki/statistics/excel/VocabularyTopByBestSpeedExcelTemplate.java b/...v/src/main/java/ru/klavogonki/statistics/excel/VocabularyTopByBestSpeedExcelTemplate.java
@@ -17,7 +17,7 @@
 
 public class VocabularyTopByBestSpeedExcelTemplate extends ExcelTemplate<PlayerVocabularyDto> {
 
-    private String sheetName;
+    private final String sheetName;
 
     public VocabularyTopByBestSpeedExcelTemplate(final String sheetName) {
         this.sheetName = sheetName;

diff --git a/...atsSrv/src/main/java/ru/klavogonki/statistics/excel/VocabularyTopByHaulExcelTemplate.java b/...atsSrv/src/main/java/ru/klavogonki/statistics/excel/VocabularyTopByHaulExcelTemplate.java
@@ -17,7 +17,7 @@
 
 public class VocabularyTopByHaulExcelTemplate extends ExcelTemplate<PlayerVocabularyDto> {
 
-    private String sheetName;
+    private final String sheetName;
 
     public VocabularyTopByHaulExcelTemplate(final String sheetName) {
         this.sheetName = sheetName;

diff --git a/.../src/main/java/ru/klavogonki/statistics/excel/VocabularyTopByRacesCountExcelTemplate.java b/.../src/main/java/ru/klavogonki/statistics/excel/VocabularyTopByRacesCountExcelTemplate.java
@@ -17,7 +17,7 @@
 
 public class VocabularyTopByRacesCountExcelTemplate extends ExcelTemplate<PlayerVocabularyDto> {
 
-    private String sheetName;
+    private final String sheetName;
 
     public VocabularyTopByRacesCountExcelTemplate(final String sheetName) {
         this.sheetName = sheetName;

diff --git a/kgstatsSrv/src/main/java/ru/klavogonki/statistics/import_db/DatabaseImporter.java b/kgstatsSrv/src/main/java/ru/klavogonki/statistics/import_db/DatabaseImporter.java
@@ -42,7 +42,7 @@ public class DatabaseImporter {
     // todo: autowire it, @see https://mapstruct.org/documentation/stable/reference/html/#using-dependency-injection
     private final PlayerVocabularyStatsMapper statsMapper = Mappers.getMapper(PlayerVocabularyStatsMapper.class);
 
-    private List<PlayerEntity> playersBatch = new ArrayList<>(); // todo: find a nicer solution
+    private final List<PlayerEntity> playersBatch = new ArrayList<>(); // todo: find a nicer solution
 
     public void importJsonToDatabase(final Config config) {
         // todo: move all related logic to a separate Spring component