Use entrypoint for dockerfile #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaitj
force-pushed
the
enh/docker-entrypoint
branch
from
7d528e8 to
6cf5dab
Compare
kaitj
force-pushed
the
enh/docker-entrypoint
branch
from
6cf5dab to
6696518
Compare
- upgrade / migrate flask db - initialize web application
kaitj
force-pushed
the
enh/docker-entrypoint
branch
from
6696518 to
23e197a
Compare
tkkuehn
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from the
CMDis that run in docker compose to an entrypoint file. This eliminates the need for manual intervention of upgrading flask dband verifying ssh keys (though with the finnicky-ness of ssh, may need to rerun.ssh-keyscanagain)Turns out trying to run an
ssh-keyscanbefore hand does not play nice with ria for docker-compose. I kept the code in for reference, but it isn't used. This ends up really just running the flask db upgrade and initializing the web application. Minor update, but I'm sure as things come up we can add to this entrypoint script.