Repo variable and config updates #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaitj
added
the
maintenance
tkkuehn
approved these changes
Oct 5, 2023
| @@ -35,7 +34,7 @@ AUTOBIDS_ARCHIVE_SSH_PORT=2222 | |||
| AUTOBIDS_ARCHIVE_SSH_KEY="~/.ssh/id_rsa.pub" | |||
| AUTOBIDS_ARCHIVE_TIMEOUT=100000 | |||
|
|
|||
| AUTOBIDS_DICOM_PI_BLACKLIST = [] | |||
| AUTOBIDS_DICOM_PI_BLACKLIST = [] | |||
There was a problem hiding this comment.
Should've noted this before, I would do AUTOBIDS_DICOM_PI_BLACKLIST="" (I don't think it will work properly otherwise)
There was a problem hiding this comment.
Hmm, I will leave this as is for now but make a mental note until we get a chance to try it out.
| @@ -82,4 +82,4 @@ ENV DCM4CHE_VERSION=5.24.1 | |||
| ENV PATH=/apps/dcm4che/dcm4che-${DCM4CHE_VERSION}/bin:/apps/DicomRaw:/apps/cfmm2tar:/opt/apptainer/bin:$PATH | |||
| ENV _JAVA_OPTIONS="-Xmx2048m" | |||
|
|
|||
| ENTRYPOINT ["/opt/autobidsportal/entrypoint.sh"] | |||
| CMD ["uwsgi", "--ini=autobidsportal.ini"] | |||
There was a problem hiding this comment.
I think you can still use the entrypoint script if you want as long as CMD is the directive
There was a problem hiding this comment.
I'll give this a shot before merging in - if it works I'll add it back in
kaitj
force-pushed
the
maint/config-update
branch
from
391473f to
98645be
Compare
Updated while meeting with Tristan, some additional notes: Production ========== can largely go from docker need singularity installed generate unit file so things run with systemd crontab for relevant commands DATALAD_SSH_IDENTITYFILE - needs access to graham - generate new ssh key on machine and add to allowed_authorized users sqlalchemy & redis set up on machine cfmm2tar and tar2bids download -> set up large storage volume on cloud service, mount on machine, add to fstab Need to be pointed at ===================== git.sharcnet.ca repository needs to be cloned on production machine mailjet - free
kaitj
force-pushed
the
maint/config-update
branch
from
98645be to
908249d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During meeting with @tkkuehn, we fixed a few bugs with the docker compose (had to go back to
CMDinstead ofENTRYPOINT). Also updated / removed variables from the.envtemplateanddocker-compose.ymlfile where appropriate.