BB template & vertex outliers #333
Conversation
|
Merging |
|
|
||
| # get unfolded grid (from 0 to 1, not world coords), using meshgrid: | ||
| # note: indexing='ij' to swap the ordering of x and y | ||
| epsilon = snakemake.params.epsilon |
There was a problem hiding this comment.
I know this PR is merged already, but easier to comment here than anew -- these changes break the rule because epsilon is not a parameter in the rule. Also, unfold_gx/unfold_gy/unfold_gz get create here, but don't actually get used .. so it seems we can just revert the create_warps changes to fix the problem, unless you were trying to do something else here?
There was a problem hiding this comment.
oh yeah, good point. Looks like we were never actually using the epsilon that we'd previously defined? I'll make a small PR to patch this & 1 other small bug i found
Also yeah points and unfold_gx somehow became redundant. We can cut the latter.
No description provided.