Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute check fix #231

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Mute check fix #231

merged 6 commits into from
Jan 30, 2024

Conversation

rougetimelord
Copy link
Collaborator

@rougetimelord rougetimelord commented Jan 29, 2024

This is a short-lived feature fix branch, once it is ready to go it should squashed and merged into main.

Changelog

  • 0.3.6
    • Fix: Check to see if an account is already muted if the mute option is active
    • Fix: Change the definition of the BlueBlockUser interface to reflect the optionality of user.legacy.blocking
    • Chore: Run prettier on global.d.ts and shared.ts
  • 0.3.7
    • Update: Use mute option while generating console messages and toasts

Deployment Checklist

  1. ensure src/manifest.ts and package.json have the correct version number
  2. use makefile to generate zips (make chrome, make firefox)
    • chrome should be tested with npm run build
    • test firefox locally using zip
  3. merge branch into main
  4. upload zips from 3 to chrome webstore and firefox addons

@rougetimelord rougetimelord changed the title Mute fix #198 Mute check fix Jan 29, 2024
cooljeanius
cooljeanius previously approved these changes Jan 29, 2024
Copy link
Collaborator

@cooljeanius cooljeanius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you've tested?

@rougetimelord
Copy link
Collaborator Author

I assume you've tested?

Tested on Chrome 120, no issues. I don't have Firefox in a testable state, sorry!

package.json Outdated Show resolved Hide resolved
src/manifest.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@cooljeanius cooljeanius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, LGTM
(I'll give others a few more hours to comment before squashing and merging)

@cooljeanius cooljeanius merged commit 8ed9701 into kheina-com:main Jan 30, 2024
2 checks passed
@rougetimelord rougetimelord deleted the mute-fix branch January 30, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Already muted accounts get queued again
2 participants