Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nft removal #237

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Nft removal #237

merged 2 commits into from
Mar 1, 2024

Conversation

rougetimelord
Copy link
Collaborator

See #228 for reasoning.

Changelog

  • Remove blockNftAvatars property from config and checks
  • Remove option from popup

Deployment Checklist

  1. ensure src/manifest.ts and package.json have the correct version number
  2. use makefile to generate zips (make chrome, make firefox)
    • chrome should be tested with npm run build
    • test firefox locally using zip
  3. merge into main
  4. upload zips from 3 to chrome webstore and firefox addons

Oops! Leaving it in ReasonMap so that users blocked in the past are still shown correctly on the history page
@cooljeanius
Copy link
Collaborator

it looks like there are some other unrelated changes in here as well? Are they just formatting, or are any of them functional changes?

@rougetimelord
Copy link
Collaborator Author

it looks like there are some other unrelated changes in here as well? Are they just formatting, or are any of them functional changes?

Those changes are from running prettier, shouldn't be any functional changes

@cooljeanius
Copy link
Collaborator

cooljeanius commented Feb 28, 2024

it looks like there are some other unrelated changes in here as well? Are they just formatting, or are any of them functional changes?

Those changes are from running prettier, shouldn't be any functional changes

OK, LGTM then (but I'll wait a day or so to give anyone else a chance to object)

@cooljeanius cooljeanius merged commit 2aa7752 into kheina-com:main Mar 1, 2024
2 checks passed
@rougetimelord rougetimelord deleted the nft-removal branch April 17, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants