Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Release Workflow #248

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Add Release Workflow #248

merged 1 commit into from
Apr 14, 2024

Conversation

kheina
Copy link
Collaborator

@kheina kheina commented Apr 13, 2024

Blue Blocker has obtained a life outside of my own efforts. To that end, I did what I could to add a new github workflow that would allow others to just create a github release and the workflow should just build and upload everything automatically

I haven't tested this yet because I'm honestly not sure how you would go about doing that without making a new release. But, I've created the necessary tokens and they are already in the repo secrets so everything should be there to make it work.

here are the actions I used in case anyone wants to double check my work:
https://github.com/marketplace/actions/publish-firefox-add-on
https://github.com/marketplace/actions/chrome-extension-upload-publish

Changelog

  • adds a github workflow to allow publishing new addon versions directly to chrome and firefox via github releases

@rougetimelord
Copy link
Collaborator

Yippie!

@cooljeanius
Copy link
Collaborator

I got the following output from actionlint on the added workflow:

$ actionlint
.github/workflows/release.yml:10:5: unexpected key "output" for "job" section. expected one of "concurrency", "container", "continue-on-error", "defaults", "env", "environment", "if", "name", "needs", "outputs", "permissions", "runs-on", "secrets", "services", "steps", "strategy", "timeout-minutes", "uses", "with" [syntax-check]
   |
10 |     output:
   |     ^~~~~~~
.github/workflows/release.yml:33:5: unexpected key "output" for "job" section. expected one of "concurrency", "container", "continue-on-error", "defaults", "env", "environment", "if", "name", "needs", "outputs", "permissions", "runs-on", "secrets", "services", "steps", "strategy", "timeout-minutes", "uses", "with" [syntax-check]
   |
33 |     output:
   |     ^~~~~~~

@kheina
Copy link
Collaborator Author

kheina commented Apr 14, 2024

I got the following output from actionlint on the added workflow:

$ actionlint
.github/workflows/release.yml:10:5: unexpected key "output" for "job" section. expected one of "concurrency", "container", "continue-on-error", "defaults", "env", "environment", "if", "name", "needs", "outputs", "permissions", "runs-on", "secrets", "services", "steps", "strategy", "timeout-minutes", "uses", "with" [syntax-check]
   |
10 |     output:
   |     ^~~~~~~
.github/workflows/release.yml:33:5: unexpected key "output" for "job" section. expected one of "concurrency", "container", "continue-on-error", "defaults", "env", "environment", "if", "name", "needs", "outputs", "permissions", "runs-on", "secrets", "services", "steps", "strategy", "timeout-minutes", "uses", "with" [syntax-check]
   |
33 |     output:
   |     ^~~~~~~

oh, it's outputs my bad

@jaredcat
Copy link
Collaborator

Petition to call this a "wokeflow"

Copy link
Collaborator

@cooljeanius cooljeanius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rougetimelord
Copy link
Collaborator

Going ahead with squashing and merging

@rougetimelord rougetimelord merged commit d6d2a62 into main Apr 14, 2024
2 checks passed
@cooljeanius cooljeanius deleted the add-release-workflow branch April 15, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants