Merged
Conversation
khoshov
reviewed
Jul 3, 2025
| field_name="published_at", | ||
| lookup_expr="gte", | ||
| ) | ||
| published_before = DateFilter( |
Owner
There was a problem hiding this comment.
Проверить не нужно ли эти поля тоже добавить в fields
khoshov
reviewed
Jul 3, 2025
apps/books/api/filters.py
Outdated
| @@ -0,0 +1,41 @@ | |||
| from django_filters import CharFilter, DateFilter, FilterSet | |||
| from apps.books.models import Book | |||
Owner
There was a problem hiding this comment.
import отформатирован не по канонам и не должно быть apps. И я бы сделал относительный импорт когда мы в том же приложении.
Owner
There was a problem hiding this comment.
khoshov
reviewed
Jul 3, 2025
apps/books/api/filters.py
Outdated
| "publisher", | ||
| "tag", | ||
| "language", | ||
| ] |
Owner
There was a problem hiding this comment.
Давай добавим папку v1
apps/books/api/v1
khoshov
reviewed
Jul 10, 2025
| @@ -0,0 +1,36 @@ | |||
| from django_filters import CharFilter, DateFilter, FilterSet | |||
Owner
There was a problem hiding this comment.
Протестистировать API наскольно получится подробно
Owner
There was a problem hiding this comment.
Поресерчить как вынести в readme процент покрытия
Owner
There was a problem hiding this comment.
khoshov
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.