Skip to content

HW6 MyNUnitWeb#10

Open
khusainovilas wants to merge 10 commits intomainfrom
task6-mynunitweb
Open

HW6 MyNUnitWeb#10
khusainovilas wants to merge 10 commits intomainfrom
task6-mynunitweb

Conversation

@khusainovilas
Copy link
Owner

No description provided.

Copy link

@yurii-litvinov yurii-litvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нетехнологично, но дело своё делает. Надо только чуть качество кода поправить

/// <param name="files">Array of uploaded DLL files.</param>
/// <returns>Returns a JSON object containing the run ID, timestamp, assembly names, and results.</returns>
[HttpPost("run")]
public async Task<IActionResult> Run([FromForm] IFormFile[]? files)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Надо, чтобы компилировалось без предупреждений

{
this.env = env;
this.db = db;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сделали бы ему основной конструктор

<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="StyleCop.Analyzers" Version="1.1.118">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StyleCop староват, надо 1.2-beta


<script src="script.js"></script>
</body>
</html>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Статическая HTML — сурово. Я бы на Razor сделал, это дало бы возможность сразу грузить историю (или что угодно) с бэкенда, без запросов к API. Но так тоже будет работать.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants