-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MBL-2043 Replace button components with new ones #2231
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2231 +/- ##
=========================================
Coverage 67.90% 67.90%
Complexity 2198 2198
=========================================
Files 356 356
Lines 23999 23999
Branches 3529 3529
=========================================
Hits 16297 16297
Misses 5856 5856
Partials 1846 1846 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 🎉
📲 What
This PR introduces a new Buttons component (
KSButtonsV2.kt
) that manages multiple button types and their respective states. Additionally, a new color management class (KSButtonsColors.kt
) has been added to ensure consistency across the design system.All buttons are now previewed in
DesignSystemActivity.kt
for validation.🤔 Why
It's part of the new Design System Implementation. This update:
KSButtonType
) to define different button variations.KSButtonsColors.kt
.🛠 How
1️⃣ Implemented
KSButtonsV2.kt
Filled
,Green
,Filled Inverted
,Filled Destructive
Borderless
,Outlined
,Outlined Destructive
,Borderless Destructive
KSButtonType
) to manage types efficiently.2️⃣ Added
KSButtonsColors.kt
for Theming3️⃣ Integrated Previews in
DesignSystemActivity.kt
👀 See
Figma designs
buttons_design_system.webm
📋 QA
1️⃣ Run
DesignSystemActivity.kt
2️⃣ Verify Button States
3️⃣ Theme Consistency
Story 📖
MBL-2043: Replace button components with new ones