Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump h2 from 1.4.197 to 2.2.220 #2356

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Conversation

tkobayas
Copy link
Contributor

@tkobayas tkobayas commented Jul 20, 2023

Bumps h2 from 1.4.197 to 2.2.220.


updated-dependencies:

  • dependency-name: com.h2database:h2 dependency-type: direct:production ...

referenced Pull Requests:

You can check Kiegroup organization repositories CI status from Chain Status webpage

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used locally on command line or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

A general local execution could be the following one, where the tool clones all dependent projects starting from the -sp one and it locally applies the pull request (if it exists) in order to reproduce a complete build scenario for the provided Pull Request.

Note: the tool considers multiple Pull Requests related to each other if their branches (generally in the forked repositories) have the same name.

$ build-chain-action -df 'https://raw.githubusercontent.com/${GROUP:kiegroup}/droolsjbpm-build-bootstrap/${BRANCH:main}/.ci/pull-request-config.yaml' build pr -url <pull-request-url> -sp kiegroup/kie-wb-distributions [--skipExecution]

Consider changing kiegroup/kie-wb-distributions with the correct starting project.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest (using this e.g. Jenkins retest this optional but no longer required)

  • for a full downstream build

    • for jenkins job: please add comment: Jenkins run fdb
    • for github actions job: add the label run_fdb
  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

  • for windows-specific os job add the label windows_check

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Bumps [h2](https://github.com/h2database/h2database) from 1.4.197 to 2.2.220.
- [Release notes](https://github.com/h2database/h2database/releases)
- [Commits](h2database/h2database@version-1.4.197...version-2.2.220)

---
updated-dependencies:
- dependency-name: com.h2database:h2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@tkobayas
Copy link
Contributor Author

Jenkins run fdb

@mareknovotny mareknovotny added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Jul 21, 2023
@tkobayas
Copy link
Contributor Author

Jenkins run fdb

1 similar comment
@tkobayas
Copy link
Contributor Author

Jenkins run fdb

@gmunozfe
Copy link
Member

@tkobayas Rerun fdb after merging this tkobayas/droolsjbpm-integration#2

@tkobayas
Copy link
Contributor Author

Jenkins run fdb

@tkobayas
Copy link
Contributor Author

Remaining failures:
jpa-workitem
camel-workitem
execute-sql-workitem
long-running-rest-workitem
jbpm-workitem-itests
jbpm-recommendation-pmml-logistic-regression
jbpm-recommendation-pmml-random-forest

They are in
https://github.com/kiegroup/jbpm-work-items
https://github.com/kiegroup/kie-jpmml-integration

I'll check tomorrow...

@gmunozfe
Copy link
Member

Remaining failures: jpa-workitem camel-workitem execute-sql-workitem long-running-rest-workitem jbpm-workitem-itests jbpm-recommendation-pmml-logistic-regression jbpm-recommendation-pmml-random-forest

They are in https://github.com/kiegroup/jbpm-work-items https://github.com/kiegroup/kie-jpmml-integration

I'll check tomorrow...

@tkobayas

For jbpm-work-items, replace those jdbc urls containing MVCC to use MODE=LEGACY and NON_KEYWORDS=VALUE (needed because CorrelationPropertyInfo table has a column named "value" and this is a reserved word for h2 and fails from version 200):

find ./ -type f -exec sed -i 's/MVCC=[Tt][Rr][Uu][Ee]/MODE=LEGACY;NON_KEYWORDS=VALUE/g' {} \;

and also createTcpServer to add ifNotExists option:

find ./ -type f -exec sed -i 's/createTcpServer(new String\[0\])/createTcpServer(new String\[\]{"-ifNotExists"})/g' {} \;

@tkobayas
Copy link
Contributor Author

@gmunozfe Thank you very much for the help! I filed 2 more PRs. Let's see.
kiegroup/jbpm-work-items#285
kiegroup/jbpm-work-items#285

@tkobayas
Copy link
Contributor Author

Jenkins run fdb

1 similar comment
@tkobayas
Copy link
Contributor Author

Jenkins run fdb

@tkobayas
Copy link
Contributor Author

FDB

[2023-07-28T10:24:34.129Z] [ERROR] Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 27.367 s <<< FAILURE! - in org.kie.wb.selenium.ui.LoginIntegrationTest

[2023-07-28T10:24:42.213Z] [ERROR] Tests run: 6, Failures: 0, Errors: 6, Skipped: 0, Time elapsed: 7.441 s <<< FAILURE! - in org.kie.wb.selenium.ui.ProjectLibraryIntegrationTest

[2023-07-28T10:24:47.477Z] [ERROR] Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 6.515 s <<< FAILURE! - in org.kie.wb.selenium.ui.LoadAllPerspectivesIntegrationTest

[2023-07-28T10:24:47.732Z] [ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.4 s <<< FAILURE! - in org.kie.wb.selenium.ui.StandalonePerspectivesIntegrationTest

@tkobayas
Copy link
Contributor Author

Jenkins run fdb

@tkobayas
Copy link
Contributor Author

tkobayas commented Aug 1, 2023

0 Failed!

Copy link
Contributor

@Ginxo Ginxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, well done @tkobayas !

@danielezonca danielezonca merged commit a30b156 into kiegroup:main Aug 1, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 1, 2023
* Bump h2 from 1.4.197 to 2.2.220

Bumps [h2](https://github.com/h2database/h2database) from 1.4.197 to 2.2.220.
- [Release notes](https://github.com/h2database/h2database/releases)
- [Commits](h2database/h2database@version-1.4.197...version-2.2.220)

---
updated-dependencies:
- dependency-name: com.h2database:h2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Upgrade hibernate version due to HHH-13711

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gonzalo Muñoz <gmunozfe@redhat.com>
github-actions bot pushed a commit that referenced this pull request Aug 1, 2023
* Bump h2 from 1.4.197 to 2.2.220

Bumps [h2](https://github.com/h2database/h2database) from 1.4.197 to 2.2.220.
- [Release notes](https://github.com/h2database/h2database/releases)
- [Commits](h2database/h2database@version-1.4.197...version-2.2.220)

---
updated-dependencies:
- dependency-name: com.h2database:h2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Upgrade hibernate version due to HHH-13711

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gonzalo Muñoz <gmunozfe@redhat.com>
danielezonca pushed a commit that referenced this pull request Aug 2, 2023
* Bump h2 from 1.4.197 to 2.2.220

Bumps [h2](https://github.com/h2database/h2database) from 1.4.197 to 2.2.220.
- [Release notes](https://github.com/h2database/h2database/releases)
- [Commits](h2database/h2database@version-1.4.197...version-2.2.220)

---
updated-dependencies:
- dependency-name: com.h2database:h2
  dependency-type: direct:production
...



* Upgrade hibernate version due to HHH-13711

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Toshiya Kobayashi <toshiyakobayashi@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gonzalo Muñoz <gmunozfe@redhat.com>
danielezonca pushed a commit that referenced this pull request Aug 2, 2023
* Bump h2 from 1.4.197 to 2.2.220

Bumps [h2](https://github.com/h2database/h2database) from 1.4.197 to 2.2.220.
- [Release notes](https://github.com/h2database/h2database/releases)
- [Commits](h2database/h2database@version-1.4.197...version-2.2.220)

---
updated-dependencies:
- dependency-name: com.h2database:h2
  dependency-type: direct:production
...



* Upgrade hibernate version due to HHH-13711

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Toshiya Kobayashi <toshiyakobayashi@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gonzalo Muñoz <gmunozfe@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants