RHPAM-4889: using a feature flag to enable/disable strict mode. #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… STRICT) to enable/disable strict mode. by default it'll continue behave as before this change.
Rikkola
approved these changes
Feb 14, 2024
elguardian
requested changes
Feb 15, 2024
There was a problem hiding this comment.
I disagree with the solution. in my opinion is not a good solution as it is to restricted.
I would create a property like
"jbpm.wb.query.location" where you can specify where to find the query definitions.
we look first in the resources on the class loader and after in the file system (if not found). so it lets the control to the user.
|
have a file provided by user is not a bad idea, in the other hand none of those files were supposed to leak to users.... and any inconsistency will break BC. I think a compromised solution, still scoping to minimal possible impact due to product:codebase lifecycle... we could have the strict file being asked by input... and strict file basically only cares about the pair of query name and target. |
|
unblocking this. but disagree with the solution as an URI will be more effective in the future. |
|
guys you merged PR change with RED CI, i will revert it |
This was referenced Feb 21, 2024
porcelli
added a commit
to porcelli/jbpm-wb
that referenced
this pull request
Feb 21, 2024
…roup#1606) * RHPAM-4889: using a feature flag (jbpm.wb.querymode values DEFAULT or STRICT) to enable/disable strict mode. by default it'll continue behave as before this change. * RHPAM-4889: reducing duplication.
|
my bad @mareknovotny - have an updated PR that re-introduces the fix without the PMD issues -> #1607 |
yesamer
pushed a commit
to yesamer/jbpm-wb
that referenced
this pull request
Mar 22, 2024
…roup#1606) * RHPAM-4889: using a feature flag (jbpm.wb.querymode values DEFAULT or STRICT) to enable/disable strict mode. by default it'll continue behave as before this change. * RHPAM-4889: reducing duplication.
mareknovotny
pushed a commit
that referenced
this pull request
Mar 26, 2024
…om openshift env vars (#1608) * RHPAM-4889: using a feature flag to enable/disable strict mode. (#1606) * RHPAM-4889: using a feature flag (jbpm.wb.querymode values DEFAULT or STRICT) to enable/disable strict mode. by default it'll continue behave as before this change. * RHPAM-4889: reducing duplication. * RHPAM-4889: adjustments to make it easier to consume from openshift env vars * Code review addressed --------- Co-authored-by: Alex Porcelli <alex@porcelli.me>
mareknovotny
added a commit
that referenced
this pull request
Jul 4, 2024
…t env vars (#1607) * RHPAM-4889: using a feature flag to enable/disable strict mode. (#1606) * RHPAM-4889: using a feature flag (jbpm.wb.querymode values DEFAULT or STRICT) to enable/disable strict mode. by default it'll continue behave as before this change. * RHPAM-4889: reducing duplication. * RHPAM-4889: adjustments to make it easier to consume from openshift env vars * to solve @tomasdavidorg review comment --------- Co-authored-by: Marek Novotný <hotmana76@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
…t env vars (#1607) * RHPAM-4889: using a feature flag to enable/disable strict mode. (#1606) * RHPAM-4889: using a feature flag (jbpm.wb.querymode values DEFAULT or STRICT) to enable/disable strict mode. by default it'll continue behave as before this change. * RHPAM-4889: reducing duplication. * RHPAM-4889: adjustments to make it easier to consume from openshift env vars * to solve @tomasdavidorg review comment --------- Co-authored-by: Marek Novotný <hotmana76@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a new environment variable
jbpm.wb.querymodewith possible values DEFAULT or STRICT.If used Strict mode, the queries will be filtered.
By default it'll continue behave as before, without filtering the queries.