Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Whitespace Issue in Migration Tool #3737

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arkitex
Copy link

@arkitex arkitex commented May 18, 2022

Fix an issue with the Migration Tool throwing errors on group names with whitespace in it.

Ran into this issue when migrating a 6.x project to 7.66.0. We had a Project name with a space in it (Ex: Example Project). The URI.create method called by the migration tool (way down in the call stack, in org/guvnor/structure/backend/organizationalunit/config/SpaceConfigStorageImpl.java) fails on whitespace, whoops!

As a fix, URLEncode the group name immediately upon launching the migration script.

Also, do it when moving data to the space config repo - unfortunately gotta do it in two places.

Tested through migrating previously failing project - this time, it passed.

@arkitex arkitex changed the title Fix Whitespace issue Fix Whitespace Issue in Migration Tool May 18, 2022
@kie-ci
Copy link

kie-ci commented May 18, 2022

Can one of the admins verify this patch?

12 similar comments
@kie-ci
Copy link

kie-ci commented May 18, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link

kie-ci commented May 18, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link

kie-ci commented May 18, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link

kie-ci commented May 18, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link

kie-ci commented May 18, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link

kie-ci commented May 18, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link

kie-ci commented May 18, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link

kie-ci commented May 18, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link

kie-ci commented May 18, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link

kie-ci commented May 18, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link

kie-ci commented May 18, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link

kie-ci commented May 18, 2022

Can one of the admins verify this patch?

@mareknovotny
Copy link
Member

it would be nice to provide also a unit test for this change @arkitex

ok to test

@sonarcloud
Copy link

sonarcloud bot commented Aug 27, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mareknovotny
Copy link
Member

jenkins retest this please

@mareknovotny
Copy link
Member

Error:

[Pipeline] { (Sonar analysis)
[Pipeline] tool
[2024-06-06T11:38:07.463Z] Invalid tool ID 20.14.0
[Pipeline] envVarsForTool
[2024-06-06T11:38:07.508Z] Invalid tool ID 20.14.0

Jenkins retest this please

@mareknovotny
Copy link
Member

unfortunately newer nodejs requires specific glib and C++ libraries installed so we have an error there:

[2024-06-06T11:03:27.460Z] [INFO] Detected os: Linux arch: amd64 alpine: false. Platform: LINUX_X64
[2024-06-06T11:03:29.982Z] [ERROR] /home/jenkins/.sonar/js/node-runtime/node: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by /home/jenkins/.sonar/js/node-runtime/node)
[2024-06-06T11:03:29.982Z] [ERROR] /home/jenkins/.sonar/js/node-runtime/node: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /home/jenkins/.sonar/js/node-runtime/node)
[2024-06-06T11:03:29.982Z] [ERROR] /home/jenkins/.sonar/js/node-runtime/node: /lib64/libstdc++.so.6: version `CXXABI_1.3.9' not found (required by /home/jenkins/.sonar/js/node-runtime/node)
[2024-06-06T11:03:29.982Z] [ERROR] /home/jenkins/.sonar/js/node-runtime/node: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /home/jenkins/.sonar/js/node-runtime/node)
[2024-06-06T11:03:29.982Z] [ERROR] /home/jenkins/.sonar/js/node-runtime/node: /lib64/libc.so.6: version `GLIBC_2.28' not found (required by /home/jenkins/.sonar/js/node-runtime/node)
[2024-06-06T11:03:29.982Z] [ERROR] /home/jenkins/.sonar/js/node-runtime/node: /lib64/libc.so.6: version `GLIBC_2.25' not found (required by /home/jenkins/.sonar/js/node-runtime/node)
[2024-06-06T11:03:29.982Z] [WARNING] Embedded Node.js failed to deploy. Will fallback to host Node.js.

@mareknovotny
Copy link
Member

jenkins retest this please

testing nodejs 18.20.2 for Sonar analysis

@mareknovotny
Copy link
Member

jenkins retest this please

1 similar comment
@pibizza
Copy link
Contributor

pibizza commented Sep 17, 2024

jenkins retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants