Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.67.x-blue] Business Central UI gets stuck when saving any project's asset #3828

Merged

Conversation

yesamer
Copy link
Member

@yesamer yesamer commented Jul 15, 2024

This issue occurs every time the DMN Validator is called (eg. when saving a DMN assets in BC) and the related project doesn't build for any reason.
In that scenario, the ClassLoader's Builder is null, and that doesn't allow the backend service to correctly behave, returning an NPE.
To fix the issue, when the Builder is null, I initialized the Validator with the default constructor (with no classloader), like it was before this change #3728

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • Retest PR: jenkins retest this
  • A full downstream build: jenkins do fdb
  • A compile downstream build: jenkins do cdb
  • A full production downstream build: jenkins do product fdb
  • An upstream build: jenkins do upstream
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@yesamer yesamer requested a review from danielzhe July 15, 2024 13:25
@yesamer yesamer changed the title Fix DMN Validation when build fails Business Central UI gets stuck when saving any project's asset Jul 15, 2024
@yesamer yesamer added the backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch label Jul 15, 2024
@yesamer yesamer changed the title Business Central UI gets stuck when saving any project's asset [7.67.x-blue] Business Central UI gets stuck when saving any project's asset Jul 15, 2024
@yesamer
Copy link
Member Author

yesamer commented Jul 15, 2024

Jenkins run fdb

@yesamer
Copy link
Member Author

yesamer commented Jul 15, 2024

jenkins retest this

3 similar comments
@yesamer
Copy link
Member Author

yesamer commented Jul 15, 2024

jenkins retest this

@yesamer
Copy link
Member Author

yesamer commented Jul 15, 2024

jenkins retest this

@yesamer
Copy link
Member Author

yesamer commented Jul 16, 2024

jenkins retest this

@yesamer
Copy link
Member Author

yesamer commented Jul 16, 2024

Pull Request build failed because of an unrelated failure with sonar. FDB was successful. Merging.

@yesamer yesamer merged commit 1a10ef1 into kiegroup:7.67.x-blue Jul 16, 2024
3 of 4 checks passed
@yesamer yesamer deleted the 7.67.x-blue_validitation_issue branch July 16, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants