Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-10218] Add italian translation #1239

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

gjed
Copy link
Contributor

@gjed gjed commented Jan 13, 2024

Add support for italian translation

JIRA: JBPM-10218

referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)

Any feedback is welcomed!


How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@mareknovotny
Copy link
Member

hi @gjed, thanks for the PR, but please use snapshot version ;) we can't accept the already released version

@gjed
Copy link
Contributor Author

gjed commented Jan 16, 2024

Rebased gjed/i18n_it on main branch @mareknovotny

Also: any advice about the dropdown menu?
Thank you!

@mareknovotny
Copy link
Member

Also: any advice about the dropdown menu?

what help/advice do you need? sorry i didn't get it ;)

@gjed
Copy link
Contributor Author

gjed commented Jan 16, 2024

what help/advice do you need? sorry i didn't get it ;)

I can't make Italian appear as an option in the language popup menu.
My understanding is that modifying the gwt.xml file should be enough, but it's not working

@mareknovotny
Copy link
Member

what help/advice do you need? sorry i didn't get it ;)

I can't make Italian appear as an option in the language popup menu. My understanding is that modifying the gwt.xml file should be enough, but it's not working

i see, i commented your PR in kie-wb-common repository where it needs to add Italian option/item into classes which populates that drop-down list, see kiegroup/kie-wb-common#3822 (comment)

@mareknovotny
Copy link
Member

ok to test

@mareknovotny
Copy link
Member

jenkins retest this please

1 similar comment
@mareknovotny
Copy link
Member

jenkins retest this please

@mareknovotny mareknovotny merged commit 409a64e into kiegroup:main Sep 17, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants