Added requested changes from review

kieler · Sep 11, 2023 · 8d8aefa · 8d8aefa
1 parent b4ce2df
commit 8d8aefa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/Server/src/routes/poi.route.ts b/Server/src/routes/poi.route.ts
@@ -196,8 +196,8 @@ export class PoiRoute {
 			properties: null
 		}
 
-		const track = (await database.tracks.getById(userData.trackId)) ?? undefined
-		if (track == undefined) {
+		const track: Track | null = await database.tracks.getById(userData.trackId)
+		if (track == null) {
 			logger.error(`Could not find track with id ${userData.trackId} to update POI with id ${userData.id}.`)
 			res.sendStatus(404)
 			return

diff --git a/Server/src/routes/track.route.ts b/Server/src/routes/track.route.ts
@@ -227,7 +227,7 @@ export class TrackRoute {
 					: undefined
 				// Also acquire the percentage position. It might happen that a percentage position is known, while the position is not.
 				// This might not make much sense.
-				const percentagePosition: number | undefined = trackKm !== null && trackKm !== undefined
+				const percentagePosition: number | undefined = trackKm != null
 					? (await TrackService.getTrackKmAsPercentage(trackKm, track)) ?? undefined
 					: undefined
 				const heading: number = await VehicleService.getVehicleHeading(vehicle)

diff --git a/Server/src/services/user.service.ts b/Server/src/services/user.service.ts
@@ -71,7 +71,7 @@ export default class UserService {
 	 */
 	public static async updateUsername(username: string, usernameChangeRequest: UsernameChangeRequest): Promise<boolean> {
 		// Check if input was valid
-		if (username !== usernameChangeRequest.oldUsername || usernameChangeRequest.newUsername !== "") {
+		if (username !== usernameChangeRequest.oldUsername || usernameChangeRequest.newUsername === "") {
 			return false
 		}