Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ote/fta #11

Merged
merged 66 commits into from
Oct 13, 2023
Merged

Ote/fta #11

merged 66 commits into from
Oct 13, 2023

Conversation

OrhanTekin
Copy link
Collaborator

No description provided.

@Drakae Drakae self-requested a review July 6, 2023 09:16
Drakae
Drakae requested changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@Drakae Drakae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally to the comments, please merge the master into your branch.

extension/package.json Outdated Show resolved Hide resolved
extension/package.json Outdated Show resolved Hide resolved
extension/package.json Outdated Show resolved Hide resolved
extension/src-language-server/fta.langium Outdated Show resolved Hide resolved
extension/src-language-server/fta.langium Outdated Show resolved Hide resolved
extension/src-webview/helper-methods.ts Outdated Show resolved Hide resolved
extension/src-webview/options/cut-set-registry.ts Outdated Show resolved Hide resolved
extension/src-webview/options/cut-set-registry.ts Outdated Show resolved Hide resolved
extension/src-webview/options/cut-set-registry.ts Outdated Show resolved Hide resolved
extension/src-webview/views.tsx Outdated Show resolved Hide resolved
Drakae
Drakae requested changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@Drakae Drakae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally to the comments, please merge the master into your branch.

Eddykasp
Eddykasp reviewed Oct 10, 2023
View reviewed changes
extension/package.json Show resolved Hide resolved
extension/src-language-server/fta/analysis/fta-cutSet-calculator.ts Show resolved Hide resolved
extension/src-language-server/fta/diagram/fta-layout-config.ts Outdated Show resolved Hide resolved
extension/src-language-server/fta/diagram/fta-layout-config.ts Outdated Show resolved Hide resolved
extension/src-webview/fta/fta-views.tsx Show resolved Hide resolved
extension/src-webview/views-rendering.tsx Outdated Show resolved Hide resolved
extension/src-webview/views-rendering.tsx Outdated Show resolved Hide resolved
extension/src-webview/views-rendering.tsx Outdated Show resolved Hide resolved
extension/src-webview/views-rendering.tsx Outdated Show resolved Hide resolved
extension/src/language-extension.ts Show resolved Hide resolved
Eddykasp
Eddykasp approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@Eddykasp Eddykasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@Drakae Drakae merged commit ca454b5 into master Oct 13, 2023
1 check passed
@Drakae Drakae deleted the ote/fta branch October 13, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eddykasp Eddykasp Eddykasp approved these changes

@Drakae Drakae Drakae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OrhanTekin @Eddykasp @Drakae