Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #27: upgrade gems, add more rubocop plugins #28

Merged
merged 3 commits into from
Jun 30, 2024

Conversation

kigster
Copy link
Owner

@kigster kigster commented Jun 30, 2024

  • Bump up Ruby versions
  • Deprecate Ruby 2.5
  • Fix Rubocop errors
  • Bump version to 0.4.0
  • Upgrades CodeCov

@kigster kigster self-assigned this Jun 30, 2024
@kigster kigster linked an issue Jun 30, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.81%. Comparing base (ccc6084) to head (03a607c).

Files Patch % Lines
lib/puma/daemon/runner_adapter.rb 0.00% 3 Missing ⚠️
lib/puma/daemon/version.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   84.33%   81.81%   -2.52%     
==========================================
  Files           7        7              
  Lines          83       77       -6     
==========================================
- Hits           70       63       -7     
- Misses         13       14       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kigster kigster force-pushed the kig/puma-rubocop-update branch 2 times, most recently from 4a3165a to f170a6e Compare June 30, 2024 21:38
 * Bump up Ruby versions
 * Deprecate Ruby 2.5
 * Fix Rubocop errors
 * Bump version to 0.4.0
 * Upgrade CodeCov; don't fail CI
@kigster kigster added work-in-progress This is being worked on ready-for-merge and removed work-in-progress This is being worked on labels Jun 30, 2024
@kigster kigster merged commit fe58304 into master Jun 30, 2024
7 checks passed
@kigster kigster deleted the kig/puma-rubocop-update branch June 30, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update puma-daemon to wider use of Rubocop
1 participant