Skip to content

Fix release failure #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reshmabidikar merged 15 commits into from
Jun 21, 2025
Merged

Fix release failure #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
51d27f9
debug release failure
reshmabidikar Jun 20, 2025
ad26660
Merge pull request #184 from reshmabidikar/debug-release-issues
reshmabidikar Jun 20, 2025
ef223ad
Fix local pom modifications
reshmabidikar Jun 20, 2025
90faa7a
Fix snapshot workflow
reshmabidikar Jun 20, 2025
fb907dd
Fix snapshot workflow
reshmabidikar Jun 20, 2025
cf76bdd
[maven-release-plugin] prepare release killbill-commons-0.26.8
killbillio Jun 20, 2025
887c2b8
[maven-release-plugin] prepare for next development iteration
killbillio Jun 20, 2025
346094e
Update parent pom to 0.146.54
reshmabidikar Jun 20, 2025
4a5156b
[maven-release-plugin] prepare release killbill-commons-0.26.9
killbillio Jun 20, 2025
5b107bb
[maven-release-plugin] prepare for next development iteration
killbillio Jun 20, 2025
5d37020
Use setupjava-v3 and add project names
reshmabidikar Jun 20, 2025
94ffe98
add distribution
reshmabidikar Jun 20, 2025
25e4002
undo temp change in release.yml
reshmabidikar Jun 20, 2025
01a4746
[maven-release-plugin] prepare release killbill-commons-0.26.10
killbillio Jun 20, 2025
1693e48
[maven-release-plugin] prepare for next development iteration
killbillio Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,6 @@ jobs:
uses: actions/setup-java@v1
with:
java-version: 11
- name: Configure Sonatype mirror
uses: s4u/maven-settings-action@v2.3.0
# Go to Sonatype directly to avoid delay syncs (could get rid of this if actions/setup-java were to support mirrors).
with:
mirrors: '[{"id": "oss-releases", "name": "Sonatype releases", "mirrorOf": "*", "url": "https://oss.sonatype.org/content/repositories/releases/"}]'
- name: Download Java dependencies
# We do as much as we can, but it may not be enough (https://issues.apache.org/jira/browse/MDEP-82)
run: |
Expand All @@ -69,28 +64,29 @@ jobs:
# Will be pushed as part of the release process, only if the release is successful
git commit -m "pom.xml: update killbill-oss-parent to ${{ github.event.inputs.parent_version }}"
- name: Configure settings.xml for release
uses: actions/setup-java@v1
uses: actions/setup-java@v3
with:
java-version: 11
server-id: ossrh-releases
server-username: OSSRH_USER
server-password: OSSRH_PASS
distribution: temurin
server-id: central
server-username: MAVEN_USERNAME
server-password: MAVEN_PASSWORD
gpg-private-key: ${{ secrets.GPG_SIGNING_KEY }}
gpg-passphrase: GPG_PASSPHRASE
- name: Release artifacts
if: github.event.inputs.perform_version == ''
env:
OSSRH_USER: ${{ secrets.OSSRH_USER }}
OSSRH_PASS: ${{ secrets.OSSRH_PASS }}
MAVEN_USERNAME: ${{ secrets.MAVEN_USERNAME }}
MAVEN_PASSWORD: ${{ secrets.MAVEN_PASSWORD }}
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
# It will still check the remote but hopefully not download much (0 B at 0 B/s). -o isn't safe because of MDEP-82 (see above).
run: |
mvn ${MAVEN_FLAGS} release:clean release:prepare release:perform
- name: Perform release
if: github.event.inputs.perform_version != ''
env:
OSSRH_USER: ${{ secrets.OSSRH_USER }}
OSSRH_PASS: ${{ secrets.OSSRH_PASS }}
MAVEN_USERNAME: ${{ secrets.MAVEN_USERNAME }}
MAVEN_PASSWORD: ${{ secrets.MAVEN_PASSWORD }}
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
# It will still check the remote but hopefully not download much (0 B at 0 B/s). -o isn't safe because of MDEP-82 (see above).
# See https://issues.apache.org/jira/browse/SCM-729 for why the release.properties file is required.
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/snapshot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ jobs:
snapshot:
uses: killbill/gh-actions-shared/.github/workflows/snapshot.yml@main
secrets:
OSSRH_USER: ${{ secrets.OSSRH_USER }}
OSSRH_PASS: ${{ secrets.OSSRH_PASS }}
MAVEN_USERNAME: ${{ secrets.MAVEN_USERNAME }}
MAVEN_PASSWORD: ${{ secrets.MAVEN_PASSWORD }}
1 change: 1 addition & 0 deletions .idea/misc.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion automaton/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>org.kill-bill.commons</groupId>
<artifactId>killbill-commons</artifactId>
<version>0.26.8-SNAPSHOT</version>
<version>0.26.11-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>killbill-automaton</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion clock/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>org.kill-bill.commons</groupId>
<artifactId>killbill-commons</artifactId>
<version>0.26.8-SNAPSHOT</version>
<version>0.26.11-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>killbill-clock</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion concurrent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>org.kill-bill.commons</groupId>
<artifactId>killbill-commons</artifactId>
<version>0.26.8-SNAPSHOT</version>
<version>0.26.11-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>killbill-concurrent</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion config-magic/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>org.kill-bill.commons</groupId>
<artifactId>killbill-commons</artifactId>
<version>0.26.8-SNAPSHOT</version>
<version>0.26.11-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>killbill-config-magic</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion embeddeddb/common/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>org.kill-bill.commons</groupId>
<artifactId>killbill-embeddeddb</artifactId>
<version>0.26.8-SNAPSHOT</version>
<version>0.26.11-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>killbill-embeddeddb-common</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion embeddeddb/h2/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>org.kill-bill.commons</groupId>
<artifactId>killbill-embeddeddb</artifactId>
<version>0.26.8-SNAPSHOT</version>
<version>0.26.11-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>killbill-embeddeddb-h2</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion embeddeddb/mysql/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>org.kill-bill.commons</groupId>
<artifactId>killbill-embeddeddb</artifactId>
<version>0.26.8-SNAPSHOT</version>
<version>0.26.11-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>killbill-embeddeddb-mysql</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion embeddeddb/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>org.kill-bill.commons</groupId>
<artifactId>killbill-commons</artifactId>
<version>0.26.8-SNAPSHOT</version>
<version>0.26.11-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>killbill-embeddeddb</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion embeddeddb/postgresql/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>org.kill-bill.commons</groupId>
<artifactId>killbill-embeddeddb</artifactId>
<version>0.26.8-SNAPSHOT</version>
<version>0.26.11-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>killbill-embeddeddb-postgresql</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion jdbi/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>org.kill-bill.commons</groupId>
<artifactId>killbill-commons</artifactId>
<version>0.26.8-SNAPSHOT</version>
<version>0.26.11-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>killbill-jdbi</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion locker/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>org.kill-bill.commons</groupId>
<artifactId>killbill-commons</artifactId>
<version>0.26.8-SNAPSHOT</version>
<version>0.26.11-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>killbill-locker</artifactId>
Expand Down
3 changes: 2 additions & 1 deletion metrics-api/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,10 @@
<parent>
<groupId>org.kill-bill.commons</groupId>
<artifactId>killbill-commons</artifactId>
<version>0.26.8-SNAPSHOT</version>
<version>0.26.11-SNAPSHOT</version>
</parent>
<artifactId>killbill-metrics-api</artifactId>
<name>KillBill Metrics API</name>
<properties>
<check.spotbugs-exclude-filter-file>spotbugs-exclude.xml</check.spotbugs-exclude-filter-file>
</properties>
Expand Down
3 changes: 2 additions & 1 deletion metrics/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,10 @@
<parent>
<groupId>org.kill-bill.commons</groupId>
<artifactId>killbill-commons</artifactId>
<version>0.26.8-SNAPSHOT</version>
<version>0.26.11-SNAPSHOT</version>
</parent>
<artifactId>killbill-metrics</artifactId>
<name>KillBill Metrics</name>
<properties>
<check.spotbugs-exclude-filter-file>spotbugs-exclude.xml</check.spotbugs-exclude-filter-file>
</properties>
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@
<parent>
<groupId>org.kill-bill.billing</groupId>
<artifactId>killbill-oss-parent</artifactId>
<version>0.146.39</version>
<version>0.146.54</version>
</parent>
<groupId>org.kill-bill.commons</groupId>
<artifactId>killbill-commons</artifactId>
<version>0.26.8-SNAPSHOT</version>
<version>0.26.11-SNAPSHOT</version>
<packaging>pom</packaging>
<name>killbill-commons</name>
<description>Kill Bill reusable Java components</description>
Expand Down
2 changes: 1 addition & 1 deletion queue/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>org.kill-bill.commons</groupId>
<artifactId>killbill-commons</artifactId>
<version>0.26.8-SNAPSHOT</version>
<version>0.26.11-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>killbill-queue</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion skeleton/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>org.kill-bill.commons</groupId>
<artifactId>killbill-commons</artifactId>
<version>0.26.8-SNAPSHOT</version>
<version>0.26.11-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>killbill-skeleton</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion utils/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>org.kill-bill.commons</groupId>
<artifactId>killbill-commons</artifactId>
<version>0.26.8-SNAPSHOT</version>
<version>0.26.11-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion xmlloader/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>org.kill-bill.commons</groupId>
<artifactId>killbill-commons</artifactId>
<version>0.26.8-SNAPSHOT</version>
<version>0.26.11-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>killbill-xmlloader</artifactId>
Expand Down
Loading