Skip to content

Added new rubocop extensions#19

Merged
tungleduyxyz merged 1 commit intomasterfrom
kaui_4.8
Apr 7, 2026
Merged

Added new rubocop extensions#19
tungleduyxyz merged 1 commit intomasterfrom
kaui_4.8

Conversation

@tungleduyxyz
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates RuboCop configuration by adding additional RuboCop extension gems and enabling their cop departments, alongside a few small code tweaks to satisfy/align with the expanded linting ruleset.

Changes:

  • Add rubocop-performance, rubocop-rails, and rubocop-thread_safety to the development Gemfile group and require them from .rubocop.yml.
  • Enable Rails/Performance/ThreadSafety departments in .rubocop.yml and set TargetRubyVersion.
  • Minor refactors: prefer post routes over match ... via: :post, and replace states.values.include? with states.value?.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Gemfile Adds RuboCop extension gems to support additional cop departments.
.rubocop.yml Requires/enables the new RuboCop extensions and configures Ruby target version.
config/routes.rb Uses explicit post route declarations instead of match ... via: :post.
app/controllers/payment_test/payments_controller.rb Uses Hash#value? for cleaner/faster value checks.
test/test_helper.rb Simplifies support file requiring (removes redundant sorting step).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tungleduyxyz tungleduyxyz merged commit 70fccdb into master Apr 7, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants