Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates RuboCop configuration by adding additional RuboCop extension gems and enabling their cop departments, alongside a few small code tweaks to satisfy/align with the expanded linting ruleset.
Changes:
- Add
rubocop-performance,rubocop-rails, andrubocop-thread_safetyto the development Gemfile group and require them from.rubocop.yml. - Enable Rails/Performance/ThreadSafety departments in
.rubocop.ymland setTargetRubyVersion. - Minor refactors: prefer
postroutes overmatch ... via: :post, and replacestates.values.include?withstates.value?.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
Gemfile |
Adds RuboCop extension gems to support additional cop departments. |
.rubocop.yml |
Requires/enables the new RuboCop extensions and configures Ruby target version. |
config/routes.rb |
Uses explicit post route declarations instead of match ... via: :post. |
app/controllers/payment_test/payments_controller.rb |
Uses Hash#value? for cleaner/faster value checks. |
test/test_helper.rb |
Simplifies support file requiring (removes redundant sorting step). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pierre
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: killbill/killbill-admin-ui#345