fix(kyc): prevent URL params cleanup on failure and add error toasts

[KaruG1999]

Description:

Fixes #771. Improves KYC callback UX by preserving URL parameters on API failure, allowing users to retry.

Changes:

• Logic: Moved window.history.replaceState inside the success block (if (res.ok)).

• Feedback: Added toast.error() for API and network failures.

Verification:

• Logic verified via static analysis.

• bun lint passed (Biome).

ℹ️ Note: End-to-end visual testing was limited due to local environment constraints (mocked auth/DB), but the implementation strictly follows the issue logic.

P.S. If any issues arise during the review or a full reproduction is needed, I can set up the complete environment with real variables. I remain available for any further improvements or requested changes.

closes #771

Summary by CodeRabbit

• Bug Fixes
  • Users now see clear on-screen notifications when KYC profile updates fail, replacing silent console errors.
  • KYC update flow preserves query parameters until the API call succeeds; URL cleanup and page refresh now occur only after a successful update.
  • Page reliably reflects updated KYC status after a successful submission.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[vercel]

@KaruG1999 is attempting to deploy a commit to the kindfi Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

Deferred URL param cleanup until the KYC API update returns success; added a centralized KYC error message and user-facing toasts on API/fetch failures; moved history replacement to success path and retain params on failure; page reload retained only after successful update.

Changes

Cohort / File(s)	Summary
KYC Callback Error Handling apps/web/components/sections/profile/profile-dashboard.tsx	Added kycUpdateErrorMessage constant; moved window.history.replaceState({}, '', '/profile') to occur only after res.ok; replaced generic console.error with specific messages and showing a toast on API error or fetch exception; removed unconditional URL cleanup; kept page reload only after success.

Sequence Diagram(s)

sequenceDiagram
    actor User
    participant Component as ProfileDashboard
    participant API as KYC API
    participant UI as Toast/History

    User->>Component: Return from KYC flow (with query params)
    Component->>API: POST callback/update request
    alt API Success
        API-->>Component: 200 OK
        Component->>UI: window.history.replaceState('/profile')
        Component->>UI: window.location.reload()
        Component-->>User: Profile refreshed
    else API Failure
        API-->>Component: non-OK response
        Component->>UI: show toast(kycUpdateErrorMessage)
        Note over Component: URL params retained for retry
    else Fetch Error
        API--xComponent: network/exception
        Component->>UI: show toast(kycUpdateErrorMessage)
        Note over Component: URL params retained for retry
    end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A callback returned with query in hand,
Toasts now speak where errors stand.
Params wait patient for the verity,
Success clears the path — retry's sincerity. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically summarizes the main changes: preventing URL cleanup on failure and adding error toasts for the KYC flow.
Linked Issues check	✅ Passed	The PR successfully addresses all coding requirements from issue #771: conditional URL cleanup on success, error toast notifications, and page reload only after successful updates.
Out of Scope Changes check	✅ Passed	All changes are directly aligned with the KYC callback error handling objectives; no unrelated or out-of-scope modifications were introduced.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@apps/web/components/sections/profile/profile-dashboard.tsx`:
- Around line 162-174: Extract the repeated KYC failure message used in the two
toast.error calls into a single constant (e.g. KYC_UPDATE_ERROR) in the
profile-dashboard component and replace both toast.error(...) usages with that
constant; update the code surrounding the success branch (the
window.history.replaceState and window.location.reload calls) to still use the
same constant only for the error branches so the message is centralized and
easier to localize/manage in the future.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@apps/web/components/sections/profile/profile-dashboard.tsx`:
- Around line 168-174: The current promise chain shows
toast.error(kycUpdateErrorMessage) in both the non-ok branch and the .catch(),
but lacks error logging; update the handler so that when res.json() fails, when
the response is non-ok, or when the fetch throws, you log the actual error
(e.g., console.error or the app logger) before calling
toast.error(kycUpdateErrorMessage); specifically add logging in the else block
that currently calls toast.error(kycUpdateErrorMessage) and inside the .catch()
so the thrown error object is recorded while retaining the user-facing toast.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@apps/web/components/sections/profile/profile-dashboard.tsx`:
- Around line 169-172: The console.error in profile-dashboard.tsx that currently
logs a static message when KYC update fails should include the HTTP response
details to aid observability: inside the same error handling/catch where
kycUpdateErrorMessage is used, extract and include the response status (and
optionally response body) from the caught error (e.g., error.response?.status
and error.response?.data or using AxiosError typing), and pass those into the
processLogger/console.error call along with the existing message and
kycUpdateErrorMessage so you can distinguish 4xx vs 5xx failures; update the
console.error call near kycUpdateErrorMessage to include these response details
and use optional chaining/null checks to avoid throwing when response is absent.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
kindfi	Ready	Preview, Comment	Jan 30, 2026 6:41pm

[Bran18]

LGTM, thanks for including the suggestion that Coderabit made. I know he can be a bit overwhelming at times, but the solution you implemented is very effective, and the user will be notified via the toast, which is always a good thing.

[KaruG1999]

Gracias maee, me gustó mucho el proyecto y el coderabbit también, aunque sea exigente 🫰​🥴​