Update invite refCode to allow a string, add supplier, city, salutation and additionalParams #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on and additionalParams
Remove var dump when status was not 200
Author
|
@DennisLammers I've tagged these changes and some more, including a php8.5 deprecation warning, in my fork: [https://github.com/uxico-dev/php-klanten-vertellen-api/releases/tag/1.2.0 If you are interested in merging my changes back to this repo I will happily create a new PR with all changes and unpublish my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refcode field does not have to be an int, it could also be some string.
The supplier, city and additionalparams are officially supported so it would be nice to be able to pass those too.
The salutation field is undocumented, but does work the same as when entered in the interface when passed.