QA 2 #4

kingsley-einstein · 2024-12-23T10:50:37Z

Resolves #46

…ributions-scan into local-development

kingsley-einstein · 2024-12-24T19:35:25Z

/scanContributions

ubiquity-os-kernel-personal · 2024-12-24T19:35:34Z

{
  "gentlementlegen": {},
  "Keyrxng": {},
  "0x4007": {
    "pull_request.mentioned": 1,
    "pull_request.subscribed": 1,
    "pull_request.commented": 3,
    "pull_request_review.changes_requested": 1,
    "pull_request_review_comment.created": 1
  },
  "ubiquity-os[bot]": {},
  "rndquu": {},
  "kingsley-einstein": {
    "pull_request.commented": 5,
    "pull_request.assigned": 1,
    "pull_request.cross-referenced": 1,
    "pull_request.convert_to_draft": 1,
    "pull_request.ready_for_review": 1,
    "+1": 1,
    "heart": 1,
    "hooray": 1
  },
  "whck6": {},
  "ubiquity-os-kernel-personal[bot]": {
    "pull_request.commented": 4
  },
  "EresDev": {
    "pull_request.mentioned": 1,
    "pull_request.subscribed": 1
  },
  "caller": "scanContributions"
}

kingsley-einstein · 2024-12-24T19:37:05Z

/scanContributions

ubiquity-os-kernel-personal · 2024-12-24T19:37:15Z

{
  "gentlementlegen": {},
  "Keyrxng": {},
  "0x4007": {
    "pull_request.mentioned": 1,
    "pull_request.subscribed": 1,
    "pull_request.commented": 3,
    "pull_request_review.changes_requested": 1,
    "pull_request_review_comment.created": 1
  },
  "ubiquity-os[bot]": {},
  "rndquu": {},
  "kingsley-einstein": {
    "pull_request.commented": 6,
    "pull_request.assigned": 1,
    "pull_request.cross-referenced": 1,
    "pull_request.convert_to_draft": 1,
    "pull_request.ready_for_review": 1,
    "pull_request.labeled": 1,
    "+1": 1,
    "heart": 1,
    "hooray": 1
  },
  "whck6": {},
  "ubiquity-os-kernel-personal[bot]": {
    "pull_request.commented": 5
  },
  "EresDev": {
    "pull_request.mentioned": 1,
    "pull_request.subscribed": 1
  },
  "caller": "scanContributions"
}

0x4007 · 2024-12-25T18:36:19Z

@gentlementlegen @whilefoo do you think this is ready for use in a rewards scheme?

I feel like there should be config added in but I'm not sure how it would be tested because generated rewards currently only happen in text-conversation-rewards.

gentlementlegen · 2024-12-25T19:17:42Z

It could be usable but not sure how to intend to communicate or handle rewards since this is its own plugin. What's the flow, in your mind?

0x4007 · 2024-12-25T20:44:45Z

We are supposed to change the kernel architecture to support "payment permit requests"

Each plugin then should be able to return a permit request

The kernel should post the combined sum of permits when the issue is closed as complete.

gentlementlegen · 2024-12-26T00:38:40Z

It seems to mix the kernel and plugins within the same codebase, transforming the kernel into a monolith doing everything. I think it would make more sense to enable the "passing data" to other plugins functionality so this one runs first then passes down the output to text-conversation-rewards. We also moved the permit generation to its own plugin as an endpoint so any plugin can just request a plugin generation which sounds simpler.

kingsley-einstein · 2024-12-26T08:09:09Z

/scanContributions

0x4007 · 2024-12-26T08:36:31Z

We also moved the permit generation to its own plugin as an endpoint so any plugin can just request a plugin generation which sounds simpler.

The main point is that we need to make this a separate plugin and it needs to be able to generate permits so whats the next steps looking like? Seems that when we accept this we still cant use it.

gentlementlegen · 2024-12-26T08:46:23Z

Right now, to generate permits, you need to include the permits npm package. If we deploy the endpoint, the plugin should just call that endpoint and get the results.

ubiquity-os/permit-generation#96

kingsley-einstein · 2024-12-26T12:53:24Z

/scanContributions

ubiquity-os-kernel-personal · 2024-12-26T12:53:37Z

{
  "gentlementlegen": {
    "pull_request.mentioned": 1,
    "pull_request.subscribed": 1,
    "pull_request.commented": 3
  },
  "Keyrxng": {},
  "0x4007": {
    "pull_request.mentioned": 1,
    "pull_request.subscribed": 1,
    "pull_request.commented": 6,
    "pull_request_review.changes_requested": 1,
    "pull_request_review_comment.created": 1
  },
  "ubiquity-os[bot]": {},
  "rndquu": {},
  "kingsley-einstein": {
    "pull_request.commented": 8,
    "pull_request.assigned": 1,
    "pull_request.cross-referenced": 1,
    "pull_request.convert_to_draft": 1,
    "pull_request.ready_for_review": 1,
    "pull_request.labeled": 1,
    "+1": 1,
    "heart": 1,
    "hooray": 1
  },
  "whck6": {},
  "ubiquity-os-kernel-personal[bot]": {
    "pull_request.commented": 6
  },
  "EresDev": {
    "pull_request.mentioned": 1,
    "pull_request.subscribed": 1
  },
  "MentleGentlemen": {
    "pull_request.mentioned": 1,
    "pull_request.subscribed": 1
  },
  "whilefoo": {
    "pull_request.mentioned": 1,
    "pull_request.subscribed": 1
  },
  "caller": "scanContributions"
}

kingsley-einstein · 2025-01-01T18:17:39Z

@0x4007
What do you think?

whilefoo · 2025-01-01T20:54:20Z

We also moved the permit generation to its own plugin as an endpoint so any plugin can just request a plugin generation which sounds simpler.

Since we plan on aggregating rewards then the plugin should tell the kernel the reward and the kernel will store this information somewhere and the permit will be generated when the user cashes out on pay.ubq.fi, unless we leave plugins the ability to bypass our system and generate "raw" permits if they wish

0x4007 · 2025-01-01T23:09:28Z

Alright so do we accept this as is and not be able to use it or do you guys have clear instructions of changes that should be implemented so we can use this after accepting?

gentlementlegen · 2025-01-08T06:33:08Z

For the required changes:

this should probably listen to "issue.closed" events
the result should be a JSON that is sent back to the kernel
it seems that all the workflow files are empty? (or is it a GitHub display problem)
bun should be used in favor of yarn

I think we could reimplement plugin communication within the kernel so that the output is this one is sent to text-conversation-rewards to take this into account for the final result. Because we care about only one unified permit with all the results in the end, correct?

gentlementlegen · 2025-01-08T06:33:33Z

.github/.ubiquity-os.config.dev.yml

This should be deleted.

gentlementlegen · 2025-01-08T06:36:09Z

src/helpers/validator.ts


-export async function returnDataToKernel(repoToken: string, stateId: string, output: object, eventType = "return-data-to-ubiquity-os-kernel") {
+export async function returnDataToKernel(


This is obsolete and would be handled by the SDK.

gentlementlegen · 2025-01-08T06:36:50Z

src/types/context.ts

@@ -9,7 +9,7 @@ import { Logs } from "@ubiquity-dao/ubiquibot-logger";
 *
 * ubiquity:listeners: ["issue_comment.created", ...]
 */
-export type SupportedEventsU = "issue_comment.created" | "issue_comment.deleted" | "issue_comment.edited";
+export type SupportedEventsU = "issue_comment.created" | "issue_comment.edited";


We don't want to listen to these events but rather issue closed.

gentlementlegen · 2025-01-08T06:37:11Z

src/types/plugin-inputs.ts

@@ -23,7 +23,7 @@ export const pluginSettingsSchema = T.Object(
    configurableResponse: T.String(),
    customStringsUrl: T.Optional(T.String()),
  },
-  { default: { configurableResponse: "Hello, world!" } }
+  { default: { configurableResponse: "This is the UbiquityOS contributions scanner." } }


Should be removed.

gentlementlegen · 2025-01-08T06:38:05Z

wrangler.toml

-compatibility_date = "2024-05-23"
-node_compat = true
+compatibility_date = "2024-11-27"
+compatibility_flags = ["nodejs_compat"]



Wrangler should not be needed as this probably should run as an Action.

whilefoo · 2025-01-08T11:42:20Z

I think we could reimplement plugin communication within the kernel so that the output is this one is sent to text-conversation-rewards to take this into account for the final result. Because we care about only one unified permit with all the results in the end, correct?

We had some problems with KV, so I don't know if it's wise to enable plugin communication without fixing the problem (I can't find the issue about this). Alternatively we could make this as part of a module inside text-conversation-rewards

gentlementlegen · 2025-01-08T12:28:56Z

@whilefoo the problem was our quota. I think we can optimize it by checking if plugins are in chains and if so not storing results in KV, which was a proposal from @0x4007 but in the end we ended up removing it altogether because we actually never used it. Maybe here would be a first good use case?

Otherwise yes as you say it could be a module there, we were trying splitting things because this plugin is becoming a huge monolith piling up functionalities.

0x4007 · 2025-01-24T10:12:55Z

@gentlementlegen you should import this into text-conversation-rewards to use this. Perhaps you can create a new task and handle it? Otherwise is this ready to accept?

whilefoo · 2025-01-24T20:50:40Z

I can move the logic into text-conversation-rewards as a module and make a PR

ubiquity-os bot and others added 30 commits October 31, 2024 20:22

chore: updated generated configuration

b13ab8a

chore: update tests

30396e8

chore: update tests

255adec

chore: update tests

edcccd3

chore: updated generated configuration

b59a754

chore: update worker file - append necessary keys to webhook payload

7ed9b96

Merge branch 'local-development' of github.com:kingsley-einstein/cont…

d63f64a

…ributions-scan into local-development

chore: updated generated configuration

a84e69c

chore: fix stats issue

6b0e649

chore: fix stats issue

c1cea68

Merge branch 'local-development' of github.com:kingsley-einstein/cont…

b23877e

…ributions-scan into local-development

chore: updated generated configuration

ca8773d

chore: track issue events

4cedae5

Merge branch 'local-development' of github.com:kingsley-einstein/cont…

e5caa73

…ributions-scan into local-development

chore: updated generated configuration

26dbe85

chore: track issue events

2d3cdc1

Merge branch 'local-development' of github.com:kingsley-einstein/cont…

5ffedbe

…ributions-scan into local-development

chore: updated generated configuration

db0c53f

chore: made requested updates

d7819c4

Merge branch 'local-development' of github.com:kingsley-einstein/cont…

19fc446

…ributions-scan into local-development

chore: made updates

7e17049

chore: updated generated configuration

83e72fe

chore: made updates

b2e672a

Merge branch 'local-development' of github.com:kingsley-einstein/cont…

05dda18

…ributions-scan into local-development

chore: fix tests, and formatting

d27dc72

chore: updated generated configuration

047e550

chore: convert to plugin

c4c544a

Merge branch 'local-development' of github.com:kingsley-einstein/cont…

0c0caf2

…ributions-scan into local-development

chore: convert to plugin

21ae8a9

chore: convert to plugin

972f52d

kingsley-einstein marked this pull request as draft December 24, 2024 19:35

kingsley-einstein marked this pull request as ready for review December 24, 2024 19:35

kingsley-einstein added the in progress label Dec 24, 2024

gentlementlegen reviewed Jan 8, 2025

View reviewed changes

.github/.ubiquity-os.config.dev.yml

Copy link

gentlementlegen Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be deleted.

gentlementlegen reviewed Jan 8, 2025

View reviewed changes

0x4007 mentioned this pull request Jan 8, 2025

/annotate ubiquity-os-marketplace/text-vector-embeddings#67

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

QA 2 #4

QA 2 #4

kingsley-einstein commented Dec 23, 2024

kingsley-einstein commented Dec 24, 2024

ubiquity-os-kernel-personal bot commented Dec 24, 2024

kingsley-einstein commented Dec 24, 2024

ubiquity-os-kernel-personal bot commented Dec 24, 2024

0x4007 commented Dec 25, 2024 •

edited

Loading

gentlementlegen commented Dec 25, 2024

0x4007 commented Dec 25, 2024

gentlementlegen commented Dec 26, 2024

kingsley-einstein commented Dec 26, 2024

0x4007 commented Dec 26, 2024

gentlementlegen commented Dec 26, 2024

kingsley-einstein commented Dec 26, 2024

ubiquity-os-kernel-personal bot commented Dec 26, 2024

kingsley-einstein commented Jan 1, 2025

whilefoo commented Jan 1, 2025

0x4007 commented Jan 1, 2025

gentlementlegen commented Jan 8, 2025 •

edited

Loading

gentlementlegen Jan 8, 2025

gentlementlegen Jan 8, 2025

gentlementlegen Jan 8, 2025

gentlementlegen Jan 8, 2025

gentlementlegen Jan 8, 2025

whilefoo commented Jan 8, 2025

gentlementlegen commented Jan 8, 2025

0x4007 commented Jan 24, 2025

whilefoo commented Jan 24, 2025


		export async function returnDataToKernel(repoToken: string, stateId: string, output: object, eventType = "return-data-to-ubiquity-os-kernel") {
		export async function returnDataToKernel(

QA 2 #4

Are you sure you want to change the base?

QA 2 #4

Conversation

kingsley-einstein commented Dec 23, 2024

kingsley-einstein commented Dec 24, 2024

ubiquity-os-kernel-personal bot commented Dec 24, 2024

kingsley-einstein commented Dec 24, 2024

ubiquity-os-kernel-personal bot commented Dec 24, 2024

0x4007 commented Dec 25, 2024 • edited Loading

gentlementlegen commented Dec 25, 2024

0x4007 commented Dec 25, 2024

gentlementlegen commented Dec 26, 2024

kingsley-einstein commented Dec 26, 2024

0x4007 commented Dec 26, 2024

gentlementlegen commented Dec 26, 2024

kingsley-einstein commented Dec 26, 2024

ubiquity-os-kernel-personal bot commented Dec 26, 2024

kingsley-einstein commented Jan 1, 2025

whilefoo commented Jan 1, 2025

0x4007 commented Jan 1, 2025

gentlementlegen commented Jan 8, 2025 • edited Loading

gentlementlegen Jan 8, 2025

Choose a reason for hiding this comment

gentlementlegen Jan 8, 2025

Choose a reason for hiding this comment

gentlementlegen Jan 8, 2025

Choose a reason for hiding this comment

gentlementlegen Jan 8, 2025

Choose a reason for hiding this comment

gentlementlegen Jan 8, 2025

Choose a reason for hiding this comment

whilefoo commented Jan 8, 2025

gentlementlegen commented Jan 8, 2025

0x4007 commented Jan 24, 2025

whilefoo commented Jan 24, 2025

0x4007 commented Dec 25, 2024 •

edited

Loading

gentlementlegen commented Jan 8, 2025 •

edited

Loading