Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/feat: support sub paths #10

Closed
wants to merge 1 commit into from
Closed

fix/feat: support sub paths #10

wants to merge 1 commit into from

Conversation

mishavantol
Copy link
Member

@mishavantol mishavantol commented Oct 24, 2020

Fixes #2 (comment)

Copy link
Member

@fruitl00p fruitl00p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make it fully recursive while you're at it? Nest it all the way down....?

@mishavantol
Copy link
Member Author

Why not make it fully recursive while you're at it? Nest it all the way down....?

Was thinking about that but I think it's not possible. E.g. set('foo.bar.baz.bla', 2) has two different intents;
a) sub-path: ['bar' => ['baz' => ['bla' => 2]]]
b) indexed by type (e.g. addresses): ['bar' => ['type' => 'baz', 'bla' => 2]]

I'm not even sure the change as it is now doesn't break some edge case I'm missing. I'll give it a second look tomorrow.

@mishavantol
Copy link
Member Author

Will close this one in favor of #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

does not support sub paths
2 participants