Remove unnecessary or self._ret_type

[evanpurkhiser]

We already do this in the _get_next function body here

croniter/src/croniter/croniter.py

Line 362 in 010b321

ret_type = ret_type or self._ret_type

[kiorky]

no, self._ret_type can be datetime, so it will be used.

[evanpurkhiser]

@kiorky Could you take a look at this again. I am not changing any functionality here.

The change is that these calls were passing

ret_type or self._ret_type

as the argument to ret_type of _get_next.

But that is unnecessary, we can just pass through the provided ret_type to the _get_next call. Even if it is None, this line in the _get_next will always default back to the self._ret_type if it was None.

croniter/src/croniter/croniter.py

Line 362 in 010b321

ret_type = ret_type or self._ret_type

I am not removing functionality I am just simplifying the code.

[kiorky]

@kiorky Could you take a look at this again. I am not changing any functionality here.

The change is that these calls were passing

ret_type or self._ret_type

as the argument to ret_type of _get_next.

But that is unnecessary, we can just pass through the provided ret_type to the _get_next call. Even if it is None, this line in the _get_next will always default back to the self._ret_type if it was None.

croniter/src/croniter/croniter.py

Line 362 in 010b321

ret_type = ret_type or self._ret_type

I am not removing functionality I am just simplifying the code.

i know, this is because the code has already been simplified and all those methods are now proxies of _get_next, but that was not always the case in earlier versions of croniter, and the idea would be to let the possibility for proxies not to have all the same behavior.

Well, let's simplify, that can be changed if we need it again.

[kiorky]

Thx again again again again again again again again again again again again for the contribution !