Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add AdonisJS to readme #165

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Conversation

RomainLanz
Copy link

@RomainLanz RomainLanz commented Mar 26, 2024

Hey there! 👋🏻

Since we added an article on how to use Kita with us (AdonisJS), I believe it makes sense to include our name here.

We are also working to improve even more the support with HMR, more helpers, and more doc around it. Good work!

Signed-off-by: Romain Lanz <2793951+RomainLanz@users.noreply.github.com>
Copy link

changeset-bot bot commented Mar 26, 2024

⚠️ No Changeset found

Latest commit: bcf6987

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Signed-off-by: Arthur Fiorette <47537704+arthurfiorette@users.noreply.github.com>
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@06ed69d). Click here to learn what that means.

❗ Current head 9adebf6 differs from pull request most recent head bcf6987. Consider uploading reports for the commit bcf6987 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             master      #165   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?         5           
  Lines             ?       465           
  Branches          ?         0           
==========================================
  Hits              ?       465           
  Misses            ?         0           
  Partials          ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arthurfiorette
Copy link
Member

Thanks!


v4.0.0 (still in beta rn) will require a different way to register and configure it... Where is the article is located? I'd love to send a PR there when v4 gets released.

Also, I'd love some help to create a oficial adonis-html-plugin, just like fastify-html-plugin with built-in support for Suspense/Streamed html and auto doctype. Could we talk sometime about it?

@arthurfiorette arthurfiorette enabled auto-merge (squash) March 26, 2024 15:56
@arthurfiorette arthurfiorette merged commit f141e58 into kitajs:master Mar 26, 2024
6 checks passed
@RomainLanz
Copy link
Author

v4.0.0 (still in beta rn) will require a different way to register and configure it... Where is the article is located? I'd love to send a PR there when v4 gets released.

Sure, the article content is hosted there:
https://github.com/adonisjs/adonisjs.com/blob/main/content/blog_posts/articles/use-tsx-for-your-template-engine.md

Also, I'd love some help to create a oficial adonis-html-plugin, just like fastify-html-plugin with built-in support for Suspense/Streamed html and auto doctype. Could we talk sometime about it?

That would be cool! I already tried the Suspense hook with our framework, and it was working very well! (also made a demo during a live stream (in french)).

@RomainLanz RomainLanz deleted the patch-1 branch March 26, 2024 21:04
@arthurfiorette
Copy link
Member

Awesome! Could you join kita's discord so we can chat later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants