Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

フロントエンドのサーバでCookieを設定する #101

Merged
merged 12 commits into from
Oct 29, 2024

Conversation

Kosei805
Copy link
Contributor

@Kosei805 Kosei805 commented Oct 28, 2024

やったこと

  • ログアウトボタンのFornタグを削除した 9a14a31
  • Cookie名から __Secureを削除した 8e604fe
  • ログイン時の通知が出るようにした e64dbfd
  • ログアウト時の通知が出るようにした 18a3e89
  • 書籍を削除したときに通知が出るようにした 9c418bc
  • React Queryのbase URLを変更した 1142955
  • フロントエンドのテストを削除した 090e30d

確認した方法

pnpm run dev

スクリーンショット

🙏

自動生成したコード

  • client/client.ts

@Kosei805 Kosei805 added the frontend frontend development label Oct 28, 2024
@Kosei805 Kosei805 requested a review from kimurash October 28, 2024 12:29
@Kosei805 Kosei805 self-assigned this Oct 28, 2024
@Kosei805 Kosei805 changed the title CookieをcrientCookieに書き換える CookieをcreateCookieに書き換える Oct 28, 2024
@kimurash kimurash changed the title CookieをcreateCookieに書き換える フロントエンドのサーバでCookieを設定する Oct 28, 2024
@kimurash kimurash marked this pull request as ready for review October 29, 2024 07:38
Copy link
Contributor Author

@Kosei805 Kosei805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです

frontend/app/routes/auth.login.tsx Show resolved Hide resolved
frontend/app/routes/home.mypage.tsx Show resolved Hide resolved
frontend/app/routes/home.mypage.tsx Show resolved Hide resolved
frontend/app/services/session.server.ts Outdated Show resolved Hide resolved
@@ -13,6 +13,10 @@ import LoginFormComponent from '~/components/login/LoginFormComponent';
import { commitSession, getSession } from '~/services/session.server';
import { errorNotifications } from '~/utils/notification';

interface LoaderData {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

個人的に、interfaceにはわかりやすい名前つけてほしい(propsとか...)

@kimurash kimurash self-assigned this Oct 29, 2024
@kimurash kimurash merged commit 993849a into main Oct 29, 2024
3 checks passed
@kimurash kimurash deleted the 100-cookie-setting branch November 2, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend frontend development
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ログインが必要なAPIにアクセスするコードでCookieを手動で設定する
2 participants