本の追加ページ(グローバル詳細ページ)の実装 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimurash
approved these changes
Nov 11, 2024
Comment on lines
14
to
28
| <BookDetailEditButton bookId={id} /> | ||
| <Button | ||
| color="red" | ||
| leftSection={<MdDeleteForever />} | ||
| fz="lg" | ||
| onClick={() => | ||
| fetcher.submit( | ||
| { bookId: id }, | ||
| { action: '/home/books/$bookId', method: 'DELETE' }, | ||
| ) | ||
| } | ||
| disabled={fetcher.state === 'submitting'} | ||
| > | ||
| 削除 | ||
| </Button> |
There was a problem hiding this comment.
粒度が揃ってなくて気持ち悪いと思ってしまった．
コンポーネントにするか直書きするか揃えた方がよくない？
| }: BookDetailControlPanelProps) => { | ||
| const [user] = useAtom(userAtom); | ||
| const fetcher = useFetcher(); | ||
| const location = useLocation(); | ||
| console.log('本の総数は', totalBook); |
| <BookDetailTitle title={book.title} /> | ||
| <GlobalBookDetailContentTable book={book} /> | ||
| <BookDetailDescription description={book.description ?? ''} /> | ||
| {bookId > 0 && <GlobalBookDetailLink bookId={bookId} />} |
There was a problem hiding this comment.
すでに登録されているか判定する分岐だと思う．
登録されていない場合bookId の値は -1 になるんだね．
undefinedの方が直感的だと思ったけどどう？
Comment on lines
32
to
37
| onCanPlay={() => | ||
| fetcher.submit(addBookData, { | ||
| action: '/home/global/books/$bookId', | ||
| method: 'POST', | ||
| }) | ||
| } |
There was a problem hiding this comment.
エディターのサポートで別のにしてたわ
Comment on lines
14
to
15
| // Google Books APIでisbnの味の検索ができるまではコメントアウト | ||
| // id={book.isbn ? Number(book.isbn) : undefined} |
|
|
||
| interface LoaderData { | ||
| searchBooksResponse: searchBooksResponse; | ||
| storageTotalBook: number; |
There was a problem hiding this comment.
ヒットした書籍の冊数だと理解した．
単純に totalBook ではダメなんだろうか？
| // 書籍の情報を取得する | ||
| const isbn = params.isbn ?? ''; | ||
| const searchBooksResponse = await searchBooks({ isbn: isbn }); | ||
| // 蔵書追加処理実装をするため蔵書の情報を取得する |
There was a problem hiding this comment.
コメントの内容
「既に登録済みであるか確認するため」の方がよくない？
| }); | ||
| } | ||
| } else { | ||
| // ログイン済みでない場合は、APIを呼び出す回数を減らすために蔵書の情報を取得しない |
There was a problem hiding this comment.
そもそも追加する権限を持ってないから最初からAPIを叩かないってことね
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
確認した方法
pnpm run devスクリーンショット
自動生成したコード