Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ローディング中のUIを実装した #142

Merged
merged 2 commits into from
Nov 17, 2024
Merged

ローディング中のUIを実装した #142

merged 2 commits into from
Nov 17, 2024

Conversation

kimurash
Copy link
Member

やったこと

タイトル参照

確認した方法

pnpm run dev

スクリーンショット

2024-11-17.12.06.19.mov

自動生成したコード

なし

@kimurash kimurash added the frontend frontend development label Nov 17, 2024
@kimurash kimurash requested a review from Kosei805 November 17, 2024 03:10
@kimurash kimurash self-assigned this Nov 17, 2024
Copy link
Contributor

@Kosei805 Kosei805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!!
結局homeのとこに書いたんやね
rootには無理そうやったんやろか
まあ、ログインはdisableになるからええか

@@ -132,6 +132,10 @@ const Home = () => {
<HeaderComponent />
<Container size="xl">
<AppShell.Main>
<LoadingOverlay
visible={navigation.state === 'loading'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visible={navigation.state !== 'idle'}
の方が良くない?
action中はオーバーレイを表示しない理由ってあるかな?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確かに!

@kimurash kimurash merged commit 5356369 into main Nov 17, 2024
3 checks passed
@kimurash kimurash deleted the 134-loading-ui branch November 17, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend frontend development
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ローディング中のUIを実装する
2 participants