Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

書籍詳細ページのテストを書いた #149

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

kimurash
Copy link
Member

やったこと

  • 書籍情報のテーブルに <tbody> を追加した bdd8617
  • サムネイルのタグから cursor 属性を削除した aaacae1
  • 書籍詳細ページのテスト bb47ce9

確認した方法

pnpm run test

@kimurash kimurash added the frontend frontend development label Nov 18, 2024
@kimurash kimurash requested a review from Kosei805 November 18, 2024 13:31
@kimurash kimurash self-assigned this Nov 18, 2024
@kimurash kimurash changed the title 141 test book detail page 書籍詳細ページのテストを書いた Nov 18, 2024
Copy link
Contributor

@Kosei805 Kosei805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです

},
}
);
expect(redirect).toHaveBeenCalledWith('/home/mypage', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここのコンフリ修正したらマージしよ

@kimurash kimurash force-pushed the 141-test-book-detail-page branch from 0afa090 to 728817e Compare November 19, 2024 14:56
@kimurash kimurash merged commit cd65902 into main Nov 19, 2024
4 checks passed
@kimurash kimurash deleted the 141-test-book-detail-page branch November 19, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend frontend development
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

書籍詳細ページのテスト
2 participants