Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

各ページのコンポーネントを routes 配下に移した #179

Merged
merged 14 commits into from
Dec 17, 2024

Conversation

kimurash
Copy link
Member

@kimurash kimurash commented Dec 16, 2024

やったこと

タイトル参照

確認した方法

pnpm run dev

@kimurash kimurash added frontend frontend development refactoring refactoring labels Dec 16, 2024
@kimurash kimurash requested review from Kosei805 and Copilot December 16, 2024 15:28
@kimurash kimurash self-assigned this Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 136 out of 136 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

backend/src/api/google-books.ts:107

  • The constant name 'GOOGLE_BOOOKS_BASE_URL' contains a typo with an extra 'O'. It should be renamed to 'GOOGLE_BOOKS_BASE_URL'.
const response = await fetch(`${GOOGLE_BOOOKS_BASE_URL}?${params}`);
@kimurash kimurash changed the title 178 relocate component 各ページのコンポーネントを routes 配下に移した Dec 16, 2024
@kimurash kimurash merged commit 5059c08 into main Dec 17, 2024
3 checks passed
@kimurash kimurash deleted the 178-relocate-component branch December 17, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend frontend development refactoring refactoring
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

各ページのコンポーネントを routes 配下に移す
1 participant