feat: realisations of optionloadr's etcd part #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zhu-mi-shan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
felix021
reviewed
Jun 19, 2024
go.mod
Outdated
| @@ -0,0 +1,62 @@ | |||
| module github.com/Printemps417/optionloader | |||
There was a problem hiding this comment.
应当是 github.com/cloudwego/optionloader
There was a problem hiding this comment.
老师，这里是不是github.com/kitex-contrib/optionloader，已修改
felix021
reviewed
Jun 19, 2024
go.mod
Outdated
| @@ -0,0 +1,62 @@ | |||
| module github.com/Printemps417/optionloader | |||
|
|
|||
| go 1.22.1 | |||
|
ci still failed, please help to fix, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
etcd
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
optionloader etcd 模块的实现
(Optional) Which issue(s) this PR fixes:
允许用户通过etcd进行服务配置，并且可以自定义config结构，自定义decode，自定义translator
(optional) The PR that updates user documentation: