Skip to content

Commit

Permalink
chore: upgrade elixir, otp and debian (#306)
Browse files Browse the repository at this point in the history
  • Loading branch information
nwittstruck authored Aug 16, 2024
1 parent b9edc03 commit 225b65b
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 22 deletions.
4 changes: 0 additions & 4 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ updates:
directory: "/assets" # Location of package manifests
schedule:
interval: "weekly"
- package-ecosystem: "docker" # See documentation for possible values
directory: "/" # Location of package manifests
schedule:
interval: "weekly"
- package-ecosystem: "github-actions" # See documentation for possible values
directory: "/" # Location of package manifests
schedule:
Expand Down
14 changes: 6 additions & 8 deletions .github/workflows/on_push_branch__execute_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
# Currently, this need to be synced manually with the Dockerfile. In the future, the workflow should be changed,
# so that a development container is built from the Dockerfile, pushed, and then re-used in the following steps.
# This would also remove the need to install cmake manually in each step:
container: hexpm/elixir:1.15.7-erlang-26.2.2-debian-bullseye-20240130-slim
container: hexpm/elixir:1.17.2-erlang-27.0.1-debian-bookworm-20240812-slim

steps:
# See https://github.com/actions/checkout
Expand Down Expand Up @@ -37,7 +37,7 @@ jobs:
# Containers must run in Linux based operating systems
runs-on: ubuntu-latest
# Docker Hub image that `container-job` executes in
container: hexpm/elixir:1.15.7-erlang-26.2.2-debian-bullseye-20240130-slim
container: hexpm/elixir:1.17.2-erlang-27.0.1-debian-bookworm-20240812-slim

needs: build_deps

Expand Down Expand Up @@ -75,8 +75,8 @@ jobs:
steps:
# Downloads a copy of the code in your repository before running CI tests
- uses: actions/checkout@v4
# we need git so that mix can access our own repo:
- run: apt-get -y update && apt-get -y install git
# we need git so that mix can access our own repo and cmake for fast_sanitize:
- run: apt-get -y update && apt-get -y install git build-essential cmake
- uses: actions/cache@v4
with:
path: |
Expand All @@ -88,16 +88,14 @@ jobs:
# install hex:
- run: mix local.hex --force && mix local.rebar --force

# we need cmake for fast_sanitize:
- run: apt-get -y update && apt-get -y install build-essential cmake
- run: mix compile
- run: mix ecto.create
- run: mix ecto.migrate
- run: mix test

check_mix_format:
runs-on: ubuntu-latest
container: hexpm/elixir:1.15.7-erlang-26.2.2-debian-bullseye-20240130-slim
container: hexpm/elixir:1.17.2-erlang-27.0.1-debian-bookworm-20240812-slim

needs: build_deps

Expand All @@ -123,7 +121,7 @@ jobs:

check_mix_sobelow:
runs-on: ubuntu-latest
container: hexpm/elixir:1.15.7-erlang-26.2.2-debian-bullseye-20240130-slim
container: hexpm/elixir:1.17.2-erlang-27.0.1-debian-bookworm-20240812-slim

needs: build_deps

Expand Down
11 changes: 5 additions & 6 deletions .sobelow-skips
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
C15BCE8CAF49A8448E904E375BA0C396
E9EC6059DDCABE1D610279F283E82FB1
010FCDAF06566172E135A670F9A9E7F4
1B0025AD5A8D1F37C31C00121BF80F14

6299080F193BA5CD21E8B020C7DA3267
6B4715EE71A5139F2F048B0135841315
76C7CB9B90E933C9501B18B9124BD05D
A9D5553F8331410859AF88EF58EA9AE9
5F304BB2A721A2DD2F7EFEFFC397C5E4
76C7CB9B90E933C9501B18B9124BD05D
C15BCE8CAF49A8448E904E375BA0C396
E9EC6059DDCABE1D610279F283E82FB1
7 changes: 3 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,16 @@
# - https://pkgs.org/ - resource for finding needed packages
# - Ex: hexpm/elixir:1.13.3-erlang-24.3.4.2-debian-bullseye-20210902-slim
#
ARG ELIXIR_VERSION=1.15.7
ARG OTP_VERSION=26.2.2
ARG DEBIAN_VERSION=bullseye-20240130-slim
ARG ELIXIR_VERSION=1.17.2
ARG OTP_VERSION=27.0.1
ARG DEBIAN_VERSION=bookworm-20240812-slim

ARG BUILDER_IMAGE="hexpm/elixir:${ELIXIR_VERSION}-erlang-${OTP_VERSION}-debian-${DEBIAN_VERSION}"
ARG RUNNER_IMAGE="debian:${DEBIAN_VERSION}"

# This is our base image for development as well as building the production image:
FROM ${BUILDER_IMAGE} as base

Check warning on line 26 in Dockerfile

View workflow job for this annotation

GitHub Actions / build-and-push-image

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/


# Install node
ENV NODE_MAJOR=20

Expand Down

0 comments on commit 225b65b

Please sign in to comment.