FIX: DeliveryOrder: Ohne Prüfung auf Bestand #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
z4m1n0
commented
Nov 23, 2024
z4m1n0
commented
sschoeling
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Sieht okay aus.
Ist das jeweils neu laden der OrderItems notwendig weil sich etwas geändert hat? Sonst könnte man die wirklich (wie ursprünglich gedacht) direkt in den transfer_requests speichern.
Auch, nicht teil dieser Änderung, aber parts_id ist eine Zahl und sollte mit == statt mit eq verglichen werden.
Wurde falsch auf Artikel des Transfers zugegriffen
z4m1n0
force-pushed
the
202411-fix-delivery_order_ignore_onhand
branch
from
c157375 to
b491eb9
Compare
|
Das Neuladen der OrderItems ist nicht notwendig. Habe es nochmal geändert. Wenn es so OK ist, dann würde ich es mergen. |
|
Jup, von mir gibt's +1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.