Test capture of nil block arguments #555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| [robotMock speak:nil afterDelay:2 whenDone:^{}]; | ||
| [robotMock speak:@"Hello" afterDelay:2 whenDone:nil]; |
There was a problem hiding this comment.
Is there a reason why you've removed the top line?
IMHO both cases are useful
There was a problem hiding this comment.
I was just making it explicit that block capture was being tested. Should I make separate test cases for normal / block capture?
There was a problem hiding this comment.
@sozorogami you can either duplicate the test or keep both lines, but both are useful since they're testing different things.
sozorogami
force-pushed
the
testNilBlockCapture
branch
from
7eed7ec
to
5709ddb
Compare
|
A bit of an ask, but any chance you can get this merged with master? I think it might be good to go if it greens ( I tried re-runnning it on travis, but it fails alas ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #446