Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extracting the type for arguments to arb files #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Dec 27, 2022

Some 3rd party modules (like for example phrase) require arb files to contain proper type names for placeholders to be able to generate code correctly. Currently when arb files are extracted from code using extract_to_arb the type is missing for placeholders and therefore code generation for the 3rd party modules generate code that doesn't compile properly.

This PR addresses it by adding the type information to MainMessage and exposing it to the generated arb file in toARB.

@robyf
Copy link

robyf commented Jan 20, 2023

I left the company where I was working and took over this on my private github account, that's why it's now reported as sent by "ghost" :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant