Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonar cleanup: WsdlFirstClientHandler #41

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Sonar cleanup: WsdlFirstClientHandler #41

merged 1 commit into from
Nov 7, 2023

Conversation

sleberknight
Copy link
Member

  • Make the Logger static and final; rename to LOG
  • Return empty Set from getHeaders instead of null
  • Add some logging in close to make Sonar happy
  • Also log when we're handling a fault, even though not doing anything

@sleberknight
Sonar cleanup: WsdlFirstClientHandler
3339f83 
* Make the Logger static and final; rename to LOG
* Return empty Set from getHeaders instead of null
* Add some logging in close to make Sonar happy
* Also log when we're handling a fault, even though not doing anything
@sleberknight sleberknight added the code cleanup Fix issues reported by Sonar or any other code analysis tools label Nov 7, 2023
@sleberknight sleberknight added this to the 0.5.0 milestone Nov 7, 2023
@sleberknight sleberknight self-assigned this Nov 7, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sleberknight sleberknight merged commit 3cdcc4a into main Nov 7, 2023
4 checks passed
@sleberknight sleberknight deleted the sonar_WsdlFirstClientHandler branch November 7, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sleberknight sleberknight

Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@sleberknight