Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Maven modules forwith Jakarta #52

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

sleberknight
Copy link
Member

Rename the two modules to replace "jaxws" with "jakarta-xml-ws"

  • dropwizard-jaxws --> dropwizard-jakarta-xml-ws
  • dropwizard-jaxws-example --> dropwizard-jakarta-xml-ws-example

Closes #51

Rename the two modules to replace "jaxws" with "jakarta-xml-ws"

* dropwizard-jaxws --> dropwizard-jakarta-xml-ws
* dropwizard-jaxws-example --> dropwizard-jakarta-xml-ws-example

Closes #51
@sleberknight sleberknight self-assigned this Nov 8, 2023
Copy link

sonarcloud bot commented Nov 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

66.5% 66.5% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sleberknight
Copy link
Member Author

Unfortunately, Sonar isn't smart enough to realize that all I did was rename the Maven modules. It thinks everything is new code, and failed the Quality Gate b/c the coverage is less than 80%. I am merging it anyway...the test coverage issues are only on the example application anyway.

@sleberknight sleberknight merged commit b4dbd49 into main Nov 8, 2023
3 of 4 checks passed
@sleberknight sleberknight deleted the 51-rename-modules branch November 8, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the Maven modules
1 participant