Fix deserialization problems in TlsContextConfiguration #1210

sleberknight · 2024-10-20T15:14:10Z

Replace Lombok constructor annotations with actual constructors such that the all-args constructor respects the default values.
Remove the Builder.Default methods since the default values are now handled in the all-args constructor.
The no-args constructor calls the all-args constructor with all null values so that defaults are in one place (instead of on field declarations and in the all-args constructor).
The all-args constructor sets the appropriate default values when it does not receive a value for a given field. It also has the ConstructorProperties annotation to help deserializers know how the arguments map to fields.
Update tests for TlsContextConfiguration and SecureEndpointsConfiguration so that deserialization from YAML is tested for both TlsContextConfiguration and SSLContextConfiguration (SecureEndpointsConfiguration extends it) using SnakeYAML, Jackson, and Dropwizard. Though Dropwizard uses Jackson and should be the same as using "plain Jackson," we want to make 100% sure Dropwizard isn't doing any kind of customization in Jackson that might change how it deserializes the YAML.
Add new helper methods in YamlTestHelper and rename the existing method so that the method names clearly express how they perform the deserialization, i.e., using SnakeYAML or Jackson.

* Replace Lombok constructor annotations with actual constructors such that the all-args constructor respects the default values. * Remove the Builder.Default methods since the default values are now handled in the all-args constructor. * The no-args constructor calls the all-args constructor with all null values so that defaults are in one place (instead of on field declarations and in the all-args constructor). * The all-args constructor sets the appropriate default values when it does not receive a value for a given field. It also has the ConstructorProperties annotation to help deserializers know how the arguments map to fields. * Update tests for TlsContextConfiguration and SecureEndpointsConfiguration so that deserialization from YAML is tested for both TlsContextConfiguration and SSLContextConfiguration (SecureEndpointsConfiguration extends it) using SnakeYAML, Jackson, and Dropwizard. Though Dropwizard uses Jackson and should be the same as using "plain Jackson," we want to make 100% sure Dropwizard isn't doing any kind of customization in Jackson that might change how it deserializes the YAML. * Add new helper methods in YamlTestHelper and rename the existing method so that the method names clearly express how they perform the deserialization, i.e., using SnakeYAML or Jackson. Closes #1209