Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to force the visual mode #2

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Add option to force the visual mode #2

merged 1 commit into from
Oct 19, 2023

Conversation

vE5li
Copy link
Contributor

@vE5li vE5li commented Oct 19, 2023

This PR gives users the ability to specify a visual mode when selecting a text object.

With this it is possible to more closely mirror the behavior of the builtin text objects, e.g. vip will always go into line-wise visual mode and vib will always go into char-wise visual mode.

While I was at it I also did a very small cleanup of the documentation, mainly removing some trailing spaces and using lua functions directly instead of wrapping them in "<cmd>lua ..."

@kiyoon
Copy link
Owner

kiyoon commented Oct 19, 2023

You can ignore the failing tests, as it's the first PR I think it wasn't tested before.
Make sure you format with Stylua, and luacheck can be ignored.

@vE5li
Copy link
Contributor Author

vE5li commented Oct 19, 2023

When running stylua lua -f stylua.toml in the root of the repository, it changes a lot of code, even files that I didn't touch. Do I need to invoke it differently?

Also, looking at the output of the format check, it looks like the stylua binary is broken or something?

@kiyoon
Copy link
Owner

kiyoon commented Oct 19, 2023

OK, maybe I forgot to delete it. The CIs are just copied from indent-blankline.nvim and not tested yet apparently. Just leave it and I'll need to review it later.

Thanks for your contribution! Although I haven't tested it myself it seems to be alright.

Does operator-pending mode work with the new settings? (dai, diI etc.)

@vE5li
Copy link
Contributor Author

vE5li commented Oct 19, 2023

Does operator-pending mode work with the new settings? (dai, diI etc.)

Works like a charm :)

@kiyoon kiyoon merged commit 39be537 into kiyoon:master Oct 19, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants