Skip to content

Commit

Permalink
Disable match_model PR check because it's too dumb
Browse files Browse the repository at this point in the history
We need to stop implementing this, but it should be defaulted to
just "return False" but we don't have a super good way to do that
really.
  • Loading branch information
kk7ds committed Nov 24, 2023
1 parent e21d78a commit 3c1ff5b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tools/check_commit.sh
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ for file in $(git diff --name-only ${BASE}..); do
fi
done

if grep 'def match_model' added_lines; then
fail 'New drivers should not have match_model() implemented as it is not needed'
fi
#if grep 'def match_model' added_lines; then
# fail 'New drivers should not have match_model() implemented as it is not needed'
#fi

if git log ${BASE}.. --merges | grep .; then
fail Please do not include merge commits in your PR
Expand Down

0 comments on commit 3c1ff5b

Please sign in to comment.